Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for memory leak in Video.FFMPEG's VideoFileWriter::Close() #406

Closed
GoogleCodeExporter opened this issue Jun 25, 2015 · 1 comment
Closed

Patch for memory leak in Video.FFMPEG's VideoFileWriter::Close() #406

GoogleCodeExporter opened this issue Jun 25, 2015 · 1 comment
Labels
auto-migrated Project-Video Type-Contribution

Comments

@GoogleCodeExporter
Copy link 

VideoFileWriter::Close() incorrectly deallocates the data->FormatContext 
structure.

According to ffmpeg's code documentation the AVFormatContext should be free'd 
with libffmpeg::avformat_free_context(AVFormatContext *s)

The entire structure end related memory is deallocated by avformat_free_context 
except for data->FormatContext->pb, which should be free'd by 
libffmpeg::avio_close(*) as shown in the attached patch

Original issue reported on code.google.com by ko...@redigo-se.net on 5 Jun 2015 at 10:15

Attachments:
@GoogleCodeExporter
Copy link
Author 

Using avformat_free_context() instead of av_free() to properly free FFmpeg's 
format context.

Committed in revision 1734.

Original comment by andrew.k...@gmail.com on 5 Jun 2015 at 11:23

  • Changed state: Fixed
  • Added labels: Project-Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Project-Video Type-Contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter