This repository has been archived by the owner on May 7, 2023. It is now read-only.
added fromStream and basic test for fromStream #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'fromStream' method to DataFrame along with a basic test for fromStream. Refactors fromCSV to rely on fromStream to avoid code duplication. Changes should be non-breaking.
Useful for writing tests that rely on parsing logic without having to construct a .csv (I'm about to add support for properly respecting escape quotes and would like to write tests without having to create a new csv for each one).
Could also be valuable to some users whose input data is coming from somewhere other than a file (eg a network connection).