on rescans, getting wrong time for new found txs

[c-e-d-git]

When the wallet scans for missing txs, new found txs are set to the actual time in the wallet transaction list instead of the time of the block they are included in.
Even with the variances in timestamps of blocks it would be better than actual time of search.
Something like min (blocktime, actual time) to prevent timestamps into the future.

[Keyare]

Is this issue related to syscoin core or BMD? Sent from Mail for Windows 10 From: cydg Sent: August 27, 2018 6:12 AM To: syscoin/syscoin Cc: Subscribed Subject: [syscoin/syscoin] on rescans, getting wrong time for new found txs(#268) When the wallet scans for missing txs, new found txs are set to the actual time in the wallet transaction list instead of the time of the block they are included in. Even with the variances in timestamps of blocks it would be better than actual time of search. Something like min (blocktime, actual time) to prevent timestamps into the future. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[c-e-d-git]

Sorry, it's core code. 99% sure inherited from btc code.
Not especially tested in BMD

[c-e-d-git]

Now tested in BMD 3.1.3:
It takes the time of the last know tx before the scan/reindex for every missing tx found.
Even more confusing than actual time of the scan.
Like said above, blocktime of tx is far better.

[Keyare]

Yes this is a known issue and we have a task assigned to fix it - or at least work around the BTC code for 3.2. We came to the same conclusion: showing the block height would be more useful than what we show presently.

…

On Fri, Sep 14, 2018 at 8:40 AM cydg ***@***.***> wrote: Now tested in BMD 3.1.3: It takes the time of the last know tx before the scan/reindex for every missing tx found. Even more confusing than actual time of the scan. Like said above, blocktime of tx is far better. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#268 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGxSz6V7z5uNx8kXma966dxbva95D00Bks5ua83YgaJpZM4WNwx0> .

[c-e-d-git]

Shouldn't be a big deal to grab the time when scanning the blocks for transactions.
i.e.
getblockhash 185000
a38ce7a0ff353b0377f0d07ddd8f91be3c6bf62c020b0e4f56ba8f313897b265

getblock a38ce7a0ff353b0377f0d07ddd8f91be3c6bf62c020b0e4f56ba8f313897b265
{
"hash": "a38ce7a0ff353b0377f0d07ddd8f91be3c6bf62c020b0e4f56ba8f313897b265",
"confirmations": 2791,
"size": 2931,
"height": 185000,
...
"time": 1536784391,
"mediantime": 1536784139,
"nonce": 0,
"bits": "1808ab60",
"difficulty": 126824300419.4244,
...
}
time or mediantime, not a big difference and close enough

[Keyare]

Closed. Deprecated version.