Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev 3.x prep 3.0.6 #227

Merged
merged 19 commits into from
Jun 22, 2018
Merged

Dev 3.x prep 3.0.6 #227

merged 19 commits into from
Jun 22, 2018

Conversation

sidhujag
Copy link
Member

Main issues fixed:

  1. Includes a hotfix for superblock creation failing when a transaction is also mined in the same block. The fees were not properly accounted for during that special block creation which caused clients to see an error message and fail to process block. If you experience this, you should upgrade to proceed to validate blocks.
  2. list service function bug fixes and cosmetic updates
  3. Ensure that dust change outputs are not created when creating syscoin transactions. Testers were complaining about seeing a dust error when updating aliases which this should fix.

sidhujag and others added 19 commits June 18, 2018 14:07
@sidhujag
Hotfix: properly account for fees in superblock calculations
87c9bb2 
IsBlockValueValid was working with blockReward variable without fees being added so when fees were added into a block we ran into issues during superblock subsidy checks.
@sidhujag
update standard reqs on regtest/testnet
c637a14
@sidhujag
remove requirement of enc keys not empty/valid
ce8d4ad
@sidhujag
fix tests and add alias test for update without funding
e4565cc
@sidhujag
don't create change if it doesn't pass dust check
f94546e
@sidhujag
set dust fee to 10k sat
541bf43
@sidhujag
fix aliasupdate
56e3005
@sidhujag
fix tests
9c593fa
@doublesharp
scanaliases updates
ee32e0b 
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
* update help text
@doublesharp
fix infinite loop, rename scan*->list*, input updates
f9f24e1 
* fix infinite loop triggered by not calling Next() on iterator
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
update help text
@doublesharp
fix typos
3983dae
@doublesharp
add help for prunesyscoinservices
e5f9bfc
Merge pull request #224 from doublesharp/dev-3.x-prep-3.0.6
8bd26f7 
scanner/list updates
@sidhujag
Fix CVE-2018-12356 by hardening the regex.
2ae1d90 
fixes and closes #219
@sidhujag
Merge branch 'dev-3.x-prep-3.0.6' of https://github.com/syscoin/syscoin…
64c89d3 
… into dev-3.x-prep-3.0.6
@sidhujag
added build version to PACKAGE_VERSION creator
05a6ec5
@willyko
Fixed gitian signer descriptor[1;2C
da7819a
Merge pull request #226 from syscoin/SYS-192-fix-signer-descriptor
193d21c 
SYS-192 Fixed gitian signer descriptor
@sidhujag
update version to 3.0.6
5e34755
@sidhujag sidhujag requested a review from willyko June 21, 2018 19:36
@sidhujag sidhujag requested a review from dwasyluk as a code owner June 21, 2018 19:36
@sidhujag sidhujag merged commit 8b00570 into dev-3.x Jun 22, 2018
@sidhujag sidhujag deleted the dev-3.x-prep-3.0.6 branch June 22, 2018 21:17
@sidhujag sidhujag mentioned this pull request Jun 22, 2018
Merged
@sidhujag sidhujag restored the dev-3.x-prep-3.0.6 branch July 3, 2018 02:47
@sidhujag sidhujag deleted the dev-3.x-prep-3.0.6 branch September 24, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willyko willyko willyko approved these changes

@dwasyluk dwasyluk Awaiting requested review from dwasyluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidhujag @willyko @doublesharp