Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 3.x #228

Merged
merged 24 commits into from
Jun 23, 2018
Merged

Dev 3.x #228

merged 24 commits into from
Jun 23, 2018

Conversation

sidhujag
Copy link
Member

3.0.6 work in this PR is based off of #227

CryptoDJ and others added 22 commits June 18, 2018 15:09
IsBlockValueValid was working with blockReward variable without fees being added so when fees were added into a block we ran into issues during superblock subsidy checks.
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
* update help text
* fix infinite loop triggered by not calling Next() on iterator
* use count=0 to return all results by setting to INT_MAX
* check that input parameters are valid
* remove "options" key and use options as root keys for ease of use
* fix CLI examples (missing single quotes, extra double quotes)
update help text
Convert Alias Name Value To Lower Case
SYS-192 Fixed gitian signer descriptor
@sidhujag sidhujag requested a review from dwasyluk as a code owner June 22, 2018 21:19
@sidhujag sidhujag requested a review from willyko June 22, 2018 21:19
dwasyluk
dwasyluk previously approved these changes Jun 22, 2018
willyko
willyko previously approved these changes Jun 22, 2018
@sidhujag sidhujag dismissed stale reviews from willyko and dwasyluk via eb8599f June 22, 2018 21:31
@willyko
Copy link

willyko commented Jun 22, 2018

Looks like travis is not running

@sidhujag sidhujag merged commit 33c0ab5 into master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants