Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about the comment in the sampling method #37

Open
zhenzhang1998 opened this issue Jul 9, 2023 · 2 comments
Open

Confusion about the comment in the sampling method #37

zhenzhang1998 opened this issue Jul 9, 2023 · 2 comments

Comments

@zhenzhang1998
Copy link

I am confused with the below setences... In train/utils/loss_mask.py Line67

    # It is crucial to calculate uncertainty based on the sampled prediction value for the points.
    # Calculating uncertainties of the coarse predictions first and sampling them for points leads
    # to incorrect results.
    # To illustrate this: assume uncertainty_func(logits)=-abs(logits), a sampled point between
    # two coarse predictions with -1 and 1 logits has 0 logits, and therefore 0 uncertainty value.
    # However, if we calculate uncertainties for the coarse predictions first,
    # both will have -1 uncertainty, and the sampled point will get -1 uncertainty.

Why the two coarse predictions with -1 and 1 logits has 0 logits, and therefore 0 uncertainty value. Is the bilinear upsample caused?

@lkeab
Copy link
Collaborator

lkeab commented Jul 10, 2023

Hi,this function comments explain the point sampling strategies when computing mask losses. It is "a sampled point between two coarse predictions with -1 and 1 logits has 0 logits", '0 logits' indicates most uncertain point thus it achieves maximal value for function -abs(logits).

@zhenzhang1998
Copy link
Author

So, Why a sampled point between two coarse predictions with -1 and 1 logits has 0 logits ? Is the bilinear upsample caused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants