Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight to @types/theme-ui in colors property #1050

Closed
deadcoder0904 opened this issue Jul 6, 2020 · 4 comments · Fixed by #1058
Closed

Add highlight to @types/theme-ui in colors property #1050

deadcoder0904 opened this issue Jul 6, 2020 · 4 comments · Fixed by #1058

Comments

@deadcoder0904
Copy link

Is your feature request related to a problem? Please describe.
Can't get autocomplete on highlight property inside colors in theme.ts

Describe the solution you'd like
highlight is missing from the @types/theme-ui package.

Don't know how the contributions work on DefinitelyTyped but as per the docs highlight property is missing in the types. I love the autocompletes guiding me in VSCode.

Also, love theme-ui's thoughtfulness into making all these properties. I don't even have to think which color to add, it's as simple as primary or highlight or muted so thanks to whoever made it :)

@jxnblk
Copy link
Member

jxnblk commented Jul 8, 2020

Theme UI is currently being rewritten in TypeScript, see #668 -- the latest is published with the theme-ui@next tag, if you want to help test it out

@deadcoder0904
Copy link
Author

Cool, I'll be testing it as I am using it with Next.js. Should I create new issues related to TypeScript or just comment it at #668?

@hasparus
Copy link
Member

hasparus commented Jul 9, 2020

Hey @deadcoder0904, I've sent DefinitelyTyped/DefinitelyTyped#45967 and #1058. Would you like to take a look at them?

@deadcoder0904
Copy link
Author

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants