Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync fans based on temp instead of duty #390

Closed
crawfxrd opened this issue Jul 29, 2023 · 4 comments · Fixed by #477
Closed

Sync fans based on temp instead of duty #390

crawfxrd opened this issue Jul 29, 2023 · 4 comments · Fixed by #477

Comments

@crawfxrd
Copy link
Member

crawfxrd commented Jul 29, 2023

The current implementation syncs all fans to the highest duty.

Replace this with syncing to the highest temperature reported by the sensors.

This will allow independent curves for FAN0 and FAN1 that work as expected based on their actual points.

Impact: Low or Medium
Rationale: Most boards use the same table for both fans. In those cases, there will be no perceived change in behavior to the user. On boards that use a different table for each fan, the different in behavior and between fans may be perceivable to the user. (Looking at existing fan points, oryp9/10 will be the most significant.)

@qnxdev
Copy link

qnxdev commented Oct 16, 2023

I highly support this, my darp9 is super hot sometimes, I have to turn on fan manually with Fn + 1 but why can't it do that job?

When I use fan it cools down the laptop such that I can put on my lap & work.

@leviport
Copy link
Member

@qnxdev this is unrelated to what you're describing. The darp9 only has a single fan, and this issue is about fan speeds on models with dual fans.

@swisscdn
Copy link

@qnxdev this is unrelated to what you're describing. The darp9 only has a single fan, and this issue is about fan speeds on models with dual fans.

So shall I raise another issue for this?

@leviport
Copy link
Member

@swisscdn No need. User-customizable fan curves are already in the works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants