Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd: fix ndisc assert 12452 #12455

Closed
wants to merge 1 commit into from

Conversation

ssahani
Copy link
Contributor

@ssahani ssahani commented May 1, 2019

allow ndisc client to configure on later stage.

The conf

[Match]
Name=enp7s0f0

[Network]
DHCP=true
IPv6PrivacyExtensions=true
IPv6AcceptRA=true <============================================
IPv6MTUBytes=1492
DNSDefaultRoute=false

[DHCP]
UseDNS=false
UseHostname=false
UseNTP=false
UseDomains=route
UseMTU=true

[IPv6AcceptRA]
UseDNS=no
UseDomains=route

The log

enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Abor

From the conf it's clear that RA accepting is enables. But hmm
initially when networkd started the ipv6ll was not there. Later
on it gained that and tried to start ndisc client . Hence crashed.
So allow ndisc client to configure on later stage.

Closes #12452

The conf
```
[Match]
Name=enp7s0f0

[Network]
DHCP=true
IPv6PrivacyExtensions=true
IPv6AcceptRA=true <============================================
IPv6MTUBytes=1492
DNSDefaultRoute=false

[DHCP]
UseDNS=false
UseHostname=false
UseNTP=false
UseDomains=route
UseMTU=true

[IPv6AcceptRA]
UseDNS=no
UseDomains=route
```

The log
```
enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Abor
Assertion 'link->radv' failed at ../systemd/src/network/networkd-link.c:1842, function link_acquire_ipv6_conf(). Aborting.
Aborted
```

From the conf it's clear that RA accepting is enables. But hmm
initially when networkd started the ipv6ll was not there. Later
on it gained that and tried to start ndisc client and radv .
Hence crashed. So allow ndisc client to configure on later stage.

Closes systemd#12452
@yuwata
Copy link
Member

yuwata commented May 2, 2019

Hmm?? Why ndisc or radv are not configured in link_configure()?

@yuwata yuwata added the network label May 2, 2019
@yuwata
Copy link
Member

yuwata commented May 2, 2019

I've submitted another approach to fix the issue in #12466.

@ssahani
Copy link
Contributor Author

ssahani commented May 3, 2019

Hmm?? Why ndisc or radv are not configured in link_configure()?

Please see the logs enp7s0f0: Gained IPv6LL. without IPv6LL they won't be configured.

@ssahani ssahani closed this May 4, 2019
@ssahani ssahani deleted the ndisc-assert-12452 branch September 21, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

networkd: Assertion 'link->ndisc' failed after bd08ce5 or 5f707e1 merged
2 participants