Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: fix assertion when link get carrier #12466

Merged
merged 1 commit into from
May 4, 2019

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented May 2, 2019

This fixes a bug introduced by bd08ce5.
When link is in LINK_STATE_INITIALIZED, Link::network may not be set yet.

Fixes #12452 and #12422 (comment).

This fixes a bug introduced by bd08ce5.
When link is in LINK_STATE_INITIALIZED, `Link::network` may not be
set yet.

Fixes systemd#12452.
@pfactum
Copy link

pfactum commented May 3, 2019

Confirming the fix for:

systemd-networkd[743]: Assertion 'link->network' failed at ../systemd-stable/src/network/networkd-link.c:1203, function link_request_set_addresses(). Aborting.

Please consider backporting both #12422 and #12466 to systemd-stable. Thanks.

@ssahani
Copy link
Contributor

ssahani commented May 4, 2019

LGTM

@cdown cdown added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label May 4, 2019
@cdown cdown merged commit 6450ee3 into systemd:master May 4, 2019
@yuwata yuwata deleted the network-fix-issue-12452 branch May 4, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed network
Development

Successfully merging this pull request may close these issues.

networkd: Assertion 'link->ndisc' failed after bd08ce5 or 5f707e1 merged
4 participants