Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd: Assertion 'link->ndisc' failed after bd08ce5 or 5f707e1 merged #12452

Closed
Just4GH opened this issue May 1, 2019 · 42 comments

Comments

@Just4GH
Copy link

commented May 1, 2019

systemd version the issue has been seen with

242.19

Used distribution

Arch Linux

Expected behaviour you didn't see

systemctl restart systemd-networkd.service doesn't fail

Unexpected behaviour you saw

Restarting systemd-networkd.service (or today it triggered on its own) fails with:

enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Aborting.

Steps to reproduce the problem

After Arch applied commits bd08ce5 and 5f707e1 to 242.0 networkd only works after a reboot.
Restarting networkd fails instantly.

The problematic interface seems to be enp7s0f0 (after assert):

# networkctl
IDX LINK             TYPE               OPERATIONAL      SETUP
  1 lo               loopback           carrier          unmanaged
  2 eno1             ether              routable         configured
  3 eno2             ether              routable         configured
  4 enp7s0f0         ether              degraded         configuring
  5 enp7s0f1         ether              off              unmanaged

5 links listed.

/etc/systemd/network/enp7s0f0.network

[Match]
Name=enp7s0f0

[Network]
DHCP=true
IPv6PrivacyExtensions=true
IPv6AcceptRA=true
IPv6MTUBytes=1492
DNSDefaultRoute=false

[DHCP]
UseDNS=false
UseHostname=false
UseNTP=false
UseDomains=route
UseMTU=true

[IPv6AcceptRA]
UseDNS=no
UseDomains=route

Staring with SYSTEMD_LOG_LEVEL=debug /usr/lib/systemd/systemd-networkd doesn't yield any more information (excerpt):

...
enp7s0f0: New device has no master, continuing without
enp7s0f0: Flags change: +UP +LOWER_UP +RUNNING +MULTICAST +BROADCAST
enp7s0f0: Link 4 added
enp7s0f0: udev initialized link
enp7s0f0: State changed: pending -> initialized
enp7s0f0: Saved original MTU: 1500
...
enp7s0f0: Adding address: fe80::.../64 (valid forever)
enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Aborting.
Aborted

ssahani added a commit to ssahani/systemd that referenced this issue May 1, 2019

networkd: fix ndisc assert 12452
allow ndisc client to configure on later stage.

The conf
```
[Match]
Name=enp7s0f0

[Network]
DHCP=true
IPv6PrivacyExtensions=true
IPv6AcceptRA=true <============================================
IPv6MTUBytes=1492
DNSDefaultRoute=false

[DHCP]
UseDNS=false
UseHostname=false
UseNTP=false
UseDomains=route
UseMTU=true

[IPv6AcceptRA]
UseDNS=no
UseDomains=route
```

The log
```
enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Abor
```

From the conf it's crear that RA accepting is enables. But hmm
initially when networkd started the ipv6ll was not there. Later
on it gailed that and tried to start ndisc client . Hence crashed.
So allow ndisc client to configure on later stage.

Closes systemd#12452
@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Very strange . From the conf it's clear that RA accepting is enabled. But hmm
initially when networkd started the ipv6ll was not there. Later
on it gained that and tried to start ndisc client . Hence crashed.
So allow ndisc client to configure on later stage.

Please try with #12455

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Well, it got a step further this time:

...
enp7s0f0: New device has no master, continuing without
enp7s0f0: Flags change: +UP +LOWER_UP +RUNNING +MULTICAST +BROADCAST
enp7s0f0: Link 4 added
enp7s0f0: udev initialized link
enp7s0f0: State changed: pending -> initialized
enp7s0f0: Saved original MTU: 1500
eno2: New device has no master, continuing without
eno2: Flags change: +UP +LOWER_UP +RUNNING +MULTICAST +BROADCAST
eno2: Link 3 added
eno2: udev initialized link
eno2: State changed: pending -> initialized
eno2: Saved original MTU: 1500
eno1: New device has no master, continuing without
eno1: Flags change: +UP +LOWER_UP +RUNNING +MULTICAST +BROADCAST
eno1: Link 2 added
eno1: udev initialized link
eno1: State changed: pending -> initialized
eno1: Saved original MTU: 9216
lo: New device has no master, continuing without
lo: Flags change: +LOOPBACK +UP +LOWER_UP +RUNNING
lo: Link 1 added
lo: udev initialized link
lo: State changed: pending -> initialized
lo: Saved original MTU: 65536
enp7s0f0: Adding address: fe80::.../64 (valid forever)
enp7s0f0: Gained IPv6LL
enp7s0f0: Discovering IPv6 routers
NDISC: Started IPv6 Router Solicitation client
enp7s0f0: Updating address: 2a0a:.../64 (valid for 1h 58min 49s)
eno2: Adding address: fe80::.../64 (valid forever)
eno2: Gained IPv6LL
Assertion 'link->radv' failed at ../systemd/src/network/networkd-link.c:1842, function link_acquire_ipv6_conf(). Aborting.
Aborted

I could'n get the Arch Linux package to compile, so I used the GIT version instead.

/etc/systemd/network/eno2.network (as it seems to stumble there now)

[Match]
Name=eno2

[Network]
Description=...
Address=192.168.1.1/24
Address=fd12:.../64
IPv6HopLimit=1
IPForward=yes
DHCP=no
LLMNR=true
LLDP=true
MulticastDNS=true
DNS=::1
#DNS=127.0.0.1
Domains=...
DNSSECNegativeTrustAnchors=...
IPv6PrefixDelegation=static


[IPv6PrefixDelegation]
RouterLifetimeSec=6000
RouterPreference=normal
DNS=fe80::...
EmitDNS=true

[IPv6Prefix]
Prefix=fd12:.../64

ssahani added a commit to ssahani/systemd that referenced this issue May 1, 2019

networkd: Allow ndisc client and radv to configure on later stage
The conf
```
[Match]
Name=enp7s0f0

[Network]
DHCP=true
IPv6PrivacyExtensions=true
IPv6AcceptRA=true <============================================
IPv6MTUBytes=1492
DNSDefaultRoute=false

[DHCP]
UseDNS=false
UseHostname=false
UseNTP=false
UseDomains=route
UseMTU=true

[IPv6AcceptRA]
UseDNS=no
UseDomains=route
```

The log
```
enp7s0f0: Gained IPv6LL
Assertion 'link->ndisc' failed at ../systemd-stable/src/network/networkd-link.c:1829, function link_acquire_ipv6_conf(). Abor
Assertion 'link->radv' failed at ../systemd/src/network/networkd-link.c:1842, function link_acquire_ipv6_conf(). Aborting.
Aborted
```

From the conf it's clear that RA accepting is enables. But hmm
initially when networkd started the ipv6ll was not there. Later
on it gained that and tried to start ndisc client and radv .
Hence crashed. So allow ndisc client to configure on later stage.

Closes systemd#12452
@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

yes it's the same situation here I forced pushed a new commit.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Looks good so far, no more asserts for the moment.

@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

yes please continue testing thanks.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Tested Clients on eno1 and eno2, still looking good.
This is networkd from Systemd 242.245 64538af + d3ede25

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Had it running in a screen session for testing, when Ctrl+C, I hit following assertion:

^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted

On a maybe unrelated note, I see quite a few IPv6: ipv6_create_tempaddr: regeneration time exceeded - disabled temporary address support in dmesg.

@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

I am able reproduce this bug

lo: New device has no master, continuing without
lo: Flags change: +LOOPBACK +UP +LOWER_UP +RUNNING
lo: Link 1 added
lo: udev initialized link
lo: State changed: pending -> initialized
lo: Saved original MTU: 65536
veth-test: Adding address: fe80::88a6:1cff:fe3f:a61a/64 (valid forever)
veth-test: Gained IPv6LL
Assertion 'link->ndisc' failed at ../src/network/networkd-link.c:1828, function link_acquire_ipv6_conf(). Aborting.
Aborted
@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Had it running in a screen session for testing, when Ctrl+C, I hit following assertion:

^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted

On a maybe unrelated note, I see quite a few IPv6: ipv6_create_tempaddr: regeneration time exceeded - disabled temporary address support in dmesg.

This seems some kind of race which valgrind should help cleaning up. This is not related.

ssahani added a commit to ssahani/systemd that referenced this issue May 2, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452
@ssahani

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

The second issue should be fixed by #12463

yuwata added a commit to yuwata/systemd that referenced this issue May 2, 2019

network: fix assertion when link get carrier
This fixes a bug introduced by bd08ce5.
When link is in LINK_STATE_INITIALIZED, `Link::network` may not be
set yet.

Fixes systemd#12452.
@yuwata

This comment has been minimized.

Copy link
Member

commented May 2, 2019

I hope the original issue can be also fixed by #12466. If possible, please also test the PR. Thank you.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 3, 2019

Just gave it a quick test with current git, no asserts so far.
Still getting the asserts when Ctrl+C though.

^CBus bus-api-network: changing state RUNNING → CLOSED
eno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted

git.log

@cdown cdown closed this in #12466 May 4, 2019

@yuwata yuwata reopened this May 4, 2019

@yuwata

This comment has been minimized.

Copy link
Member

commented May 4, 2019

(The second issue is not fixed yet. Let's reopen this.)

yuwata added a commit to yuwata/systemd that referenced this issue May 4, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452
@yuwata

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I hope the second issue is safely fixed by #12475.

yuwata added a commit to yuwata/systemd that referenced this issue May 4, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452
@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

Just checked with the latest git, no more asserts after Ctrl+C

^CBus bus-api-network: changing state RUNNING → CLOSED
eno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
free(): double free detected in tcache 2
Aborted

free(): double free detected in tcache 2 still looks suspicious.
git2.log

@yuwata

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Yeah, the failure should not related, and is #9895.

        /* let's assume that the test machine does not have a .network file
           that applies to the loopback device... */
        assert_se(network_get(manager, loopback, "lo", &mac, &network) == -ENOENT);

BTW, I updated the PR again. Please test again. The valgrind log is so helpful.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

In chroot:
SYSTEMD_LOG_LEVEL=debug valgrind -v --track-origins=yes --leak-check=full --show-leak-kinds=all /home/test/systemd-git/src/build/systemd-networkd &> /tmp/valgrind3.log
valgrind3.log

The valgrind log is so helpful.

Glad to hear this works out in a chroot.

yuwata added a commit to yuwata/systemd that referenced this issue May 4, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.
@yuwata

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Many thanks again! I found the root of the first leak in valgrind3.log and added the fix for it in the PR. But still not sure about the other leaks or unconditional jumps.

If you can help more, then please disable LTO (maybe -D b_lto=false meson option), and run networkd with SYSTEMD_MEMPOOL=0 environment variable. Then, please provide the log of valgrind. Thank you!

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

SYSTEMD_MEMPOOL=0 SYSTEMD_LOG_LEVEL=debug valgrind -v --track-origins=yes --leak-check=full --show-leak-kinds=all /home/test/systemd-git/src/build/systemd-networkd &> /tmp/valgrind4.log

valgrind4.log

Am I getting the parameters/vars right or do I need to change anything else?

Excerpt from the build:
exec meson setup --prefix /usr --libexecdir lib --sbindir bin --buildtype debug --auto-features enabled --wrap-mode nodownload -D b_lto=false -D b_pie=true systemd build -Dversion-tag=242.268-1-git -Dvalgrind=true -Dgnu-efi=true -Dima=false -Dlibidn2=true -Dlz4=true -Ddbuspolicydir=/usr/share/dbus-1/system.d -Ddefault-hierarchy=hybrid -Ddefault-locale=C -Ddefault-kill-user-processes=false -Dfallback-hostname=archlinux '-Dntp-servers=0.arch.pool.ntp.org 1.arch.pool.ntp.org 2.arch.pool.ntp.org 3.arch.pool.ntp.org' '-Ddns-servers=1.1.1.1 9.9.9.10 8.8.8.8 2606:4700:4700::1111 2620:fe::10 2001:4860:4860::8888' -Drpmmacrosdir=no -Dsysvinit-path= -Dsysvrcnd-path=

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

I completely nuked my build chroot and setup a fresh one - current build without -O2 and -D_FORTIFY_SOURCE=2

==> Starting prepare()...
patching file rules/50-udev-default.rules.in
patching file sysusers.d/basic.conf.in
From /home/test/systemd-git/systemd
 * branch                  refs/pull/12475/head -> FETCH_HEAD
Auto-merging src/network/networkd-network.c
Auto-merging src/network/networkd-link.c
Merge made by the 'recursive' strategy.
 src/libsystemd-network/sd-radv.c    |  1 +
 src/network/networkd-address-pool.c |  2 +-
 src/network/networkd-dhcp6.c        | 75 +++++++++++++++++++++++++--------------------------------------------------
 src/network/networkd-link.c         | 30 ++++++------------------------
 src/network/networkd-manager.c      | 15 +++++----------
 src/network/networkd-manager.h      |  3 +--
 src/network/networkd-network-bus.c  |  3 ++-
 src/network/networkd-network.c      | 43 ++++++++++++++++++++-----------------------
 src/network/networkd-network.h      | 10 +++++-----
 src/network/test-networkd-conf.c    |  3 ++-
 10 files changed, 68 insertions(+), 117 deletions(-)
==> Starting pkgver()...
==> Starting build()...
+ exec meson setup --prefix /usr --libexecdir lib --sbindir bin --buildtype debug --auto-features enabled --wrap-mode nodownload -D b_lto=false -D b_pie=true systemd build -Dversion-tag=242.268-1-git -Dvalgrind=true -Dgnu-efi=true -Dima=false -Dlibidn2=true -Dlz4=true -Ddbuspolicydir=/usr/share/dbus-1/system.d -Ddefault-hierarchy=hybrid -Ddefault-locale=C -Ddefault-kill-user-processes=false -Dfallback-hostname=archlinux '-Dntp-servers=0.arch.pool.ntp.org 1.arch.pool.ntp.org 2.arch.pool.ntp.org 3.arch.pool.ntp.org' '-Ddns-servers=1.1.1.1 9.9.9.10 8.8.8.8 2606:4700:4700::1111 2620:fe::10 2001:4860:4860::8888' -Drpmmacrosdir=no -Dsysvinit-path= -Dsysvrcnd-path=
...
Appending CFLAGS from environment: '-march=x86-64 -mtune=generic -pipe -fno-plt -g -fvar-tracking-assignments -fdebug-prefix-map=/home/test/systemd-git/src=/usr/src/debug'
Appending LDFLAGS from environment: '-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

SYSTEMD_MEMPOOL=0 SYSTEMD_LOG_LEVEL=debug valgrind -v --track-origins=yes --leak-check=full --show-leak-kinds=all /home/test/systemd-git/src/build/systemd-networkd &> /tmp/valgrind5.log
valgrind5.log

yuwata added a commit to yuwata/systemd that referenced this issue May 4, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.
@yuwata

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@Just4GH I've added more fixes in #12475.

Interestingly, valgrind5.log shows no error :-p
I am happy the current PR will be tested with both the optimization is enabled and disabled.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

Well, I'm afraid it didn't have enough time to produce errors. Left it running for a while and just killed it for the new test.
valgrind5-1.log

Will report back with the new fixes.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

First few minutes are looking good.
valgrind6.log

I'll let it run for a while and see if anything pops up.
If nothing shows up, I'll rebuild with none-debug options and try again.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 4, 2019

Nothing interesting while running, but Ctrl+C came up with a longer list.
valgrind6-1.log

I'll leave it running over night this time, this should include an IPv6 change on enp7s0f0.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 5, 2019

valgrind6-2.log
Now that's been running for a couple of hours and Ctrl+C has some more errors show up.

yuwata added a commit to yuwata/systemd that referenced this issue May 5, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.
@yuwata

This comment has been minimized.

Copy link
Member

commented May 5, 2019

@Just4GH I've updated PR #12475. Please test again. The huge number of leaks in the last valgrind log should come from one common root, and I hope that is fixed in the current PR.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 5, 2019

I'll give it some time, as the errors only seem to show up after quite a while.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 5, 2019

About an hour later and no errors.

==7382== HEAP SUMMARY:
==7382==     in use at exit: 0 bytes in 0 blocks
==7382==   total heap usage: 6,217 allocs, 6,217 frees, 1,522,825 bytes allocated
==7382==
==7382== All heap blocks were freed -- no leaks are possible
==7382==
==7382== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
==7382== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

I'll go back to standard options and give it another long run.

@Just4GH

This comment has been minimized.

Copy link
Author

commented May 5, 2019

Looking good.
This run only had -Dvalgrind=true added, the rest is default (-O2, LTO, etc.)

==30546== HEAP SUMMARY:
==30546==     in use at exit: 0 bytes in 0 blocks
==30546==   total heap usage: 6,671 allocs, 6,671 frees, 1,726,555 bytes allocated
==30546==
==30546== All heap blocks were freed -- no leaks are possible
==30546==
==30546== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
==30546== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Anything else we should test?

@yuwata

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Many thanks for your help! I think the above two tests are enough.

yuwata added a commit to yuwata/systemd that referenced this issue May 5, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452

yuwata added a commit to yuwata/systemd that referenced this issue May 5, 2019

yuwata added a commit to yuwata/systemd that referenced this issue May 5, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.

yuwata added a commit to yuwata/systemd that referenced this issue May 7, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452

yuwata added a commit to yuwata/systemd that referenced this issue May 7, 2019

yuwata added a commit to yuwata/systemd that referenced this issue May 7, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.

@Just4GH Just4GH closed this May 7, 2019

edevolder added a commit to edevolder/systemd that referenced this issue Jun 26, 2019

network: fix assertion when link get carrier
This fixes a bug introduced by bd08ce5.
When link is in LINK_STATE_INITIALIZED, `Link::network` may not be
set yet.

Fixes systemd#12452.

edevolder added a commit to edevolder/systemd that referenced this issue Jun 26, 2019

networkd: manager do not unef netlink and gennetlink early
Because of this the fd is getting closed and we getting errors
like
```
^Ceno1: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Could not send rtnetlink message: Bad file descriptor
enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor
Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting.
Aborted
```

Closes one of systemd#12452

edevolder added a commit to edevolder/systemd that referenced this issue Jun 26, 2019

edevolder added a commit to edevolder/systemd that referenced this issue Jun 26, 2019

sd-radv: fix memleak
Fixes one memleak found in systemd#12452.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.