network: add network_ref/_unref() and make Link object take a reference of Network object #12475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuwata networkd is crashing. Could you please fix it . thanks ! |
|
Ouch! I hope the failure is fixed now. |
yuwata
force-pushed
the
network-fix-12452
branch
5 times, most recently
from
5d0c682
to
9aee0ba
Compare
|
The CentOS CI failure is #12344. Should be unrelated. |
keszybz
reviewed
May 7, 2019
src/network/networkd-manager.c
Outdated
| return 0; | ||
| } | ||
|
|
||
| a = new(struct in6_addr, 1); |
Because of this the fd is getting closed and we getting errors like ``` ^Ceno1: Could not send rtnetlink message: Bad file descriptor enp7s0f0: Could not send rtnetlink message: Bad file descriptor enp7s0f0: Cannot delete unreachable route for DHCPv6 delegated subnet 2a0a:...:fc::/62: Bad file descriptor Assertion '*_head == _item' failed at ../systemd/src/network/networkd-route.c:126, function route_free(). Aborting. Aborted ``` Closes one of systemd#12452
Fixes the third issue in systemd#12452.
The function sd_radv_add_prefix() in dhcp6_pd_prefix_assign() may return -EEXIST, and in that case the sd_radv_prefix object allocated in dhcp6_pd_prefix_assign() will be freed when the function returns. Hence, the key value in Manager::dhcp6_prefixes hashmap is lost.
Fixes one memleak found in systemd#12452.
When address is in IPv4, the remaining buffer in in_addr_union may not be initialized. Fixes the following valgrind warning: ``` ==13169== Conditional jump or move depends on uninitialised value(s) ==13169== at 0x137FF6: UnknownInlinedFun (networkd-ndisc.c:77) ==13169== by 0x137FF6: UnknownInlinedFun (networkd-ndisc.c:580) ==13169== by 0x137FF6: ndisc_handler.lto_priv.83 (networkd-ndisc.c:597) ==13169== by 0x11BE23: UnknownInlinedFun (sd-ndisc.c:201) ==13169== by 0x11BE23: ndisc_recv.lto_priv.174 (sd-ndisc.c:254) ==13169== by 0x4AA18CF: source_dispatch (sd-event.c:2821) ==13169== by 0x4AA1BC2: sd_event_dispatch (sd-event.c:3234) ==13169== by 0x4AA1D88: sd_event_run (sd-event.c:3291) ==13169== by 0x4AA1FAB: sd_event_loop (sd-event.c:3313) ==13169== by 0x117401: UnknownInlinedFun (networkd.c:113) ==13169== by 0x117401: main (networkd.c:120) ==13169== Uninitialised value was created by a stack allocation ==13169== at 0x1753C8: manager_rtnl_process_address (networkd-manager.c:479) ```
The change in manager_rtnl_process_address() may not be necessary, but for safety, let's initialize the value.
|
@keszybz Thank you for the review. The two suggestions are addressed. |
|
bionic-amd64 fails in udev test: Not sure what to make of this, but it looks unrelated. |
keszybz
added
ci-failure-appears-unrelated
and removed
good-to-merge/with-minor-suggestions
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then,
NetDev,Network, andLinkobjects can be unrefed in arbitrary orders, and now the first commit of #12463 (EDIT: which was already dropped from #12464) can be safely applied. So, it is cherry-picked on top of that.Fixes the second issue of #12452.
@ssahani PTAL.