Improved message for syntax check #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-05-29 17:58:00 UTC |
ivotron
requested changes
May 29, 2019
cli/popper/parser.py
Outdated
| @@ -155,7 +155,8 @@ def _validate_syntax(self): | |||
| wf_block = list(self._workflow['workflow'].values())[0] | |||
| for key in wf_block.keys(): | |||
| if key not in VALID_WORKFLOW_ATTRS: | |||
| log.fail('Invalid attrs found.') | |||
| log.fail( | |||
| 'Invalid workflow attribute {} was found.'.format(key)) | |||
There was a problem hiding this comment.
can we single quote the value, i.e. "Invalid workflow attribute '{}' was found"?
| log.fail('Invalid attrs found.') | ||
| log.fail( | ||
| 'Invalid action attribute {} was ' | ||
| 'found.'.format(key)) |
ivotron
pushed a commit
that referenced
this pull request
May 24, 2020
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #657.