Add unit tests and bug fixes for scm.py #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivotron Can we make the default version returned from |
|
git repos have a default branch that is pointed to by |
ivotron
reviewed
Jul 16, 2019
There was a problem hiding this comment.
thanks @JayjeetAtGithub, this is looking great, I'm so glad we'll finally have proper unit tests. All looks good, only thing would be that we can turn off any logging from the popper commands when running unit tests. In this way we keep unittest's output clean
ivotron
requested changes
Jul 17, 2019
|
Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-17 05:59:46 UTC |
|
thanks @JayjeetAtGithub ! |
ivotron
pushed a commit
that referenced
this pull request
Jul 23, 2019
Fixes bug on scm.py that resulted in an action version not being properly checked out
ivotron
pushed a commit
that referenced
this pull request
May 24, 2020
Fixes bug on scm.py that resulted in an action version not being properly checked out
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
Fixes bug on scm.py that resulted in an action version not being properly checked out
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
Fixes bug on scm.py that resulted in an action version not being properly checked out
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
Fixes bug on scm.py that resulted in an action version not being properly checked out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for
scm.pymodule and other fixes.