Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for gha.py #730

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Adds tests for gha.py #730

merged 1 commit into from
Aug 6, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator

@JayjeetAtGithub JayjeetAtGithub commented Aug 2, 2019

Adds test for gha.py

@pep8speaks
Copy link

pep8speaks commented Aug 2, 2019

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-06 07:50:44 UTC

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #730 into master will decrease coverage by 1.78%.
The diff coverage is 96.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   89.64%   87.85%   -1.79%     
==========================================
  Files           9       11       +2     
  Lines         917     1598     +681     
==========================================
+ Hits          822     1404     +582     
- Misses         95      194      +99
Impacted Files Coverage Δ
cli/popper/utils.py 96.92% <100%> (ø) ⬆️
cli/test/test_utils.py 99.04% <100%> (ø) ⬆️
cli/popper/parser.py 97.08% <100%> (ø) ⬆️
cli/popper/gha.py 69.72% <71.42%> (ø)
cli/test/test_gha.py 98.95% <98.95%> (ø)
cli/popper/log.py 72.05% <0%> (+1.47%) ⬆️
cli/test/test_scm.py 98.91% <0%> (+8.69%) ⬆️
cli/popper/scm.py 92.38% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ab76f...c7f924c. Read the comment docs.

@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review August 6, 2019 11:11
@ivotron
Copy link
Collaborator

ivotron commented Aug 6, 2019

this is awesome. Thanks a lot!

@ivotron ivotron merged commit f603155 into master Aug 6, 2019
@ivotron ivotron deleted the jayjeet/gha_tests branch August 6, 2019 23:44
ivotron pushed a commit that referenced this pull request May 24, 2020
Last chunk of work to add unit tests.

fixes #648
ivotron pushed a commit that referenced this pull request May 25, 2020
Last chunk of work to add unit tests.

fixes #648
ivotron pushed a commit that referenced this pull request May 25, 2020
Last chunk of work to add unit tests.

fixes #648
ivotron pushed a commit that referenced this pull request May 25, 2020
Last chunk of work to add unit tests.

fixes #648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants