Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #707 Adds support for exit code 78 #735

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Fixes #707 Adds support for exit code 78 #735

merged 2 commits into from
Aug 20, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator

@JayjeetAtGithub JayjeetAtGithub commented Aug 18, 2019

Addresses #707

@pep8speaks
Copy link

pep8speaks commented Aug 18, 2019

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-19 13:36:49 UTC

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #735 into master will increase coverage by 0.82%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage      93%   93.82%   +0.82%     
==========================================
  Files          11       11              
  Lines        1686     1701      +15     
==========================================
+ Hits         1568     1596      +28     
+ Misses        118      105      -13
Impacted Files Coverage Δ
cli/popper/cli.py 41.07% <0%> (ø) ⬆️
cli/test/test_gha.py 100% <100%> (ø) ⬆️
cli/popper/gha.py 89.42% <100%> (+1.07%) ⬆️
cli/popper/log.py 85.29% <0%> (+13.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828f16e...244ff69. Read the comment docs.

ci/test/actions-demo Show resolved Hide resolved
@ivotron ivotron merged commit 442df30 into master Aug 20, 2019
@ivotron ivotron deleted the jayjeet/issue707 branch August 20, 2019 02:12
ivotron pushed a commit that referenced this pull request May 24, 2020
checks exit code of actions and ignores 78 as per the actions spec

fixes #707
ivotron pushed a commit that referenced this pull request May 25, 2020
checks exit code of actions and ignores 78 as per the actions spec

fixes #707
ivotron pushed a commit that referenced this pull request May 25, 2020
checks exit code of actions and ignores 78 as per the actions spec

fixes #707
ivotron pushed a commit that referenced this pull request May 25, 2020
checks exit code of actions and ignores 78 as per the actions spec

fixes #707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants