API to communicate with VMS #415

abhi20161997 · 2018-06-04T06:52:28Z

Description

Sending meetup data like event name, date and venue to VMS

Fixes #411

Type of Change:

Delete irrelevant options.

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

My changes generate no new warnings
New and existing unit tests pass locally with my changes

abhi20161997 · 2018-06-04T07:03:15Z

@yatna I have applied the filter for sorting.

coveralls · 2018-06-04T07:04:14Z

Coverage increased (+0.006%) to 98.662% when pulling cc3e7a9 on abhi20161997:vms_api into 00a6726 on systers:develop.

nfebe

Everything looks good, I suggest you add prefixes to all api routes... When this is merged I would create a base test which you can use a template.

nfebe · 2018-06-05T20:05:35Z

requirements/dev.txt

Ps, why does this appear as an addition?

I might have backspaced and retyped- doesn't make a difference though

nfebe · 2018-06-05T20:19:13Z

systers_portal/meetup/urls.py

@@ -135,4 +135,5 @@
        DeleteSupportRequestCommentView.as_view(),
        name="delete_support_request_comment"),
    url(r'^(?P<slug>[\w-]+)/(?P<meetup_slug>[\w-]+)/$', MeetupView.as_view(), name="view_meetup"),
+    url(r'^request_meetup_data/$', api_for_vms, name='api_for_vms'),


Why don't you add and API prefix? like api/ to make it clearer that one is dealing with API routes?

How about adding a vX prefix where X = version of our API, I've seen this followed quite much.

Yes makes sense something like api/vX (api/v1/request_meetup_data, api/v2/request_meetup_data ....)

abhi20161997 · 2018-06-06T16:40:20Z

@fenn-cs @Monal5031 I've added the prefix. Please have a look now.

abhi20161997 · 2018-06-06T16:41:14Z

@yatna . I made some changes suggested by @fenn-cs and @Monal5031 . Please can u approve again as the previous approval turned stale.

Monal5031

LGTM 👍

nfebe

Everything looks ok :)

poojithansl · 2018-06-07T11:08:49Z

systers_portal/meetup/views.py

+
+
+@api_view(['POST'])
+def api_for_vms(request):


Instead of function based views, please switch this to class based views as it has higher capabilities.

Merge pull request anitab-org#403 from abhi20161997/favicon_replace Replacing the favicon transfered and rewrote base, login and admin tests from automated testing Signed-off-by: Fenn-25 <fenn25.fn@gmail.com> api to communicate with VMS

abhi20161997 added Priority: HIGH Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jun 4, 2018

abhi20161997 force-pushed the vms_api branch from 9e34e5f to 3a11191 Compare June 4, 2018 06:58

yatna requested a review from nfebe June 4, 2018 15:03

yatna previously approved these changes Jun 4, 2018

View reviewed changes

nfebe reviewed Jun 5, 2018

View reviewed changes

mayburgos requested a review from poojithansl June 5, 2018 23:07

abhi20161997 dismissed yatna’s stale review via 2d72de3 June 6, 2018 16:27

abhi20161997 force-pushed the vms_api branch from 3a11191 to 2d72de3 Compare June 6, 2018 16:27

Monal5031 previously approved these changes Jun 6, 2018

View reviewed changes

nfebe previously approved these changes Jun 6, 2018

View reviewed changes

abhi20161997 dismissed stale reviews from nfebe and Monal5031 via f28f729 June 6, 2018 20:38

abhi20161997 force-pushed the vms_api branch 3 times, most recently from bbcb4c3 to 789732b Compare June 6, 2018 20:54

anitab-org deleted a comment Jun 6, 2018

abhi20161997 force-pushed the vms_api branch 5 times, most recently from 839235f to cc3e7a9 Compare June 6, 2018 21:59

yatna previously approved these changes Jun 7, 2018

View reviewed changes

poojithansl reviewed Jun 7, 2018

View reviewed changes

abhi20161997 added 2 commits June 8, 2018 12:45

replace favicon

fa408a0

Merge pull request anitab-org#403 from abhi20161997/favicon_replace Replacing the favicon transfered and rewrote base, login and admin tests from automated testing Signed-off-by: Fenn-25 <fenn25.fn@gmail.com> api to communicate with VMS

Merge branch 'develop' of https://github.com/systers/portal into vms_api

0c233c5

abhi20161997 dismissed yatna’s stale review via 0c233c5 June 8, 2018 07:59

abhi20161997 force-pushed the vms_api branch from cc3e7a9 to 0c233c5 Compare June 8, 2018 07:59

abhi20161997 closed this Jun 11, 2018

abhi20161997 mentioned this pull request Jun 11, 2018

API to communicate with VMS #416

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API to communicate with VMS #415

API to communicate with VMS #415

abhi20161997 commented Jun 4, 2018 •

edited

Loading

abhi20161997 commented Jun 4, 2018

coveralls commented Jun 4, 2018 •

edited

Loading

nfebe left a comment •

edited

Loading

nfebe Jun 5, 2018

abhi20161997 Jun 6, 2018

nfebe Jun 5, 2018

Monal5031 Jun 5, 2018

nfebe Jun 5, 2018

abhi20161997 commented Jun 6, 2018

abhi20161997 commented Jun 6, 2018

Monal5031 left a comment

nfebe left a comment

poojithansl Jun 7, 2018 •

edited

Loading



		@api_view(['POST'])
		def api_for_vms(request):

API to communicate with VMS #415

API to communicate with VMS #415

Conversation

abhi20161997 commented Jun 4, 2018 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

abhi20161997 commented Jun 4, 2018

coveralls commented Jun 4, 2018 • edited Loading

nfebe left a comment • edited Loading

Choose a reason for hiding this comment

nfebe Jun 5, 2018

Choose a reason for hiding this comment

abhi20161997 Jun 6, 2018

Choose a reason for hiding this comment

nfebe Jun 5, 2018

Choose a reason for hiding this comment

Monal5031 Jun 5, 2018

Choose a reason for hiding this comment

nfebe Jun 5, 2018

Choose a reason for hiding this comment

abhi20161997 commented Jun 6, 2018

abhi20161997 commented Jun 6, 2018

Monal5031 left a comment

Choose a reason for hiding this comment

nfebe left a comment

Choose a reason for hiding this comment

poojithansl Jun 7, 2018 • edited Loading

Choose a reason for hiding this comment

abhi20161997 commented Jun 4, 2018 •

edited

Loading

coveralls commented Jun 4, 2018 •

edited

Loading

nfebe left a comment •

edited

Loading

poojithansl Jun 7, 2018 •

edited

Loading