Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Minesweeper game #96

Merged
merged 8 commits into from
Jun 26, 2017
Merged

Conversation

identity2
Copy link
Contributor

Completed the prototype of the Minesweeper game.

Players can navigate to the Minesweeper game by choosing:
School Scenario -> Sure -> Sure -> Do you have condoms? -> Never mind, let's just have sex.

For now, there is only a single contraceptive method. More contraceptive methods should be added later.

@sunjunkie
Copy link
Contributor

sunjunkie commented Jun 23, 2017

The game looks good. My comments/questions:

  1. For some reason, the deployment target is 10.0 in this PR which is a change. It probably should be 9.x. Are you using some iOS 10-specific feature?

  2. I suggest making the gameIndex (MiniGameViewController.swift) an enum to be more transparent about what the index means.

  3. There is an small box in the lower right of the game. Is that from SpriteKit? Doesn't look like it is for the user.

… to enum: Int. Changed the deployment target back to iOS 9.1.
@identity2
Copy link
Contributor Author

identity2 commented Jun 24, 2017

  1. Think I accidentally changed that, I changed it back to 9.1.
  2. Yes, enum is way better than plain Int indices (I always forgot to use enum when I should 😅). Changed that.
  3. The debugging box is disabled now.

@sunjunkie sunjunkie merged commit cad1ab4 into anitab-org:GSoC17 Jun 26, 2017
@identity2 identity2 deleted the mine-sweeper-game branch July 24, 2017 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants