Enhance UI for creating shifts #120
Conversation
| @@ -12,6 +14,21 @@ def event_not_empty(event_id): | |||
| return result | |||
|
|
|||
|
|
|||
| def get_event_by_shift_id(shift_id): | |||
There was a problem hiding this comment.
New function. I did not use it, but I think it may be useful in the future.
There was a problem hiding this comment.
@vubo Can you add a comment before this function, that what this can be used and specify that it may be useful in the future. What happens is, sometimes new contributors would like to start with cleaning the already existing code, and a function which is not used anywhere becomes a victim. If we add a comment we all will remember, that yes it is not used anywhere, right now, but can be used in the future, if needed.
There was a problem hiding this comment.
@vubo @tapasweni-pathak It may be semantics but I would prefer a docstring over a comment :)
Here's a link to the Django docs: https://docs.djangoproject.com/en/1.8/internals/contributing/writing-code/coding-style/
There was a problem hiding this comment.
Yes, that only. :)
Thanks.
|
Everything else looks fine. 👍 Just one minor edit and it will ready to merge. This is coming out very nicely. 👍 💃 |
Doc string
vubo
force-pushed
the
createShiftBetter
branch
from
5486973
to
40f8826
Compare
|
@tapasweni-pathak thank you, I did it :) |
Enhance UI for creating shifts
Inspired by @willingc. Closes #100
This PR adds a pre-populate feature for creating shifts.
The shift-fields are filled with database information already know about the event (country, state, city, address, venue) to minimize typing by admin. The admin is able to override the pre-populated information.