This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Refactored unit tests #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.3%) to 93.86% when pulling 00c59a6cf21e8ba0f647d7a7ec19bab9adf00e93 on smarshy:refactor-unit into f3eda78 on systers:develop. |
|
This looks good to me. 👍 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to modularize and refactor unit tests using fixtures to eliminate duplication and database objects created. I have added class level fixtures, module level fixtures (wherever the data objects could be reused by multiple classes) and modularized the code to reuse common functions defined in utils.py
The improvements after these modifications can be viewed here
The tests have been grouped into classes based on what type of objects they are sharing so that adding a new test is easier and faster. I have also added comments to tests so that it is easier to relate which data object is used by a test.
Coverage is decreasing due to the new file utils.py
Fixes #344
Related to #369
CC @nidhimj22