Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Migrated test architecture to Page Object Model Design #375

Merged
merged 21 commits into from
Aug 24, 2016

Conversation

smarshy
Copy link
Contributor

@smarshy smarshy commented Aug 20, 2016

This PR migrates entire selenium test pattern to follow page object model design. A new app has been created for the migration. It separates pages into objects, each linked to its relevant element locators. The tests have been refactored to interact with these page objects. There is a further reduction in duplication.

Earlier, the tests were very brittle. Small changes in UI (eg. page url, selector element) would lead to a need for several changes in the tests. One had to manually search and make changes for each relevant test within a file as well as across them. By migrating the entire pattern, any change in the ui needs to be followed up with a change at only one location, thereby making the tests more maintainable and less brittle.

Since there are plenty of changes, I am linking relevant blog here
Please review and suggest changes.

Fixes #376 , #369

cc @nidhimj22 @tapasweni-pathak

@coveralls
Copy link

Coverage Status

Coverage increased (+5.02%) to 88.718% when pulling 925fd05 on smarshy:addPom into 09a6837 on systers:develop.

@tapaswenipathak
Copy link
Contributor

This looks good to me.

@nidhimj22 Let me know when you are done, I will test and merge.

@smarshy smarshy mentioned this pull request Aug 23, 2016
@tapaswenipathak tapaswenipathak merged commit 925fd05 into anitab-org:develop Aug 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants