This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Migrated test architecture to Page Object Model Design #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates entire selenium test pattern to follow page object model design. A new app has been created for the migration. It separates pages into objects, each linked to its relevant element locators. The tests have been refactored to interact with these page objects. There is a further reduction in duplication.
Earlier, the tests were very brittle. Small changes in UI (eg. page url, selector element) would lead to a need for several changes in the tests. One had to manually search and make changes for each relevant test within a file as well as across them. By migrating the entire pattern, any change in the ui needs to be followed up with a change at only one location, thereby making the tests more maintainable and less brittle.
Since there are plenty of changes, I am linking relevant blog here
Please review and suggest changes.
Fixes #376 , #369
cc @nidhimj22 @tapasweni-pathak