Tests for Event app #707

Monal5031 · 2018-06-03T16:58:53Z

Description

Tested event app

Uncommented and corrected the commented tests
Move tests from automated testing repo
Write my own tests

Fixes #702

Type of Change:

Delete irrelevant options.

Code
Quality Assurance

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test job -v 2

and to overall project use:

python manage.py test

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
[x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

Monal5031

Need some changes, multiple instances are possible for following.

Monal5031 · 2018-06-05T21:43:56Z

vms/pom/pages/eventsPage.py

@@ -113,6 +112,9 @@ def go_to_create_organization_page(self):
    def get_deletion_box(self):
        return self.element_by_class_name(self.elements.DELETION_BOX)

+    def get_delete_element(self, relative):


rename to get_delete_event_element.

Monal5031 · 2018-06-05T21:45:28Z

vms/event/tests/test_event.py

+
+    def check_error_messages(self):
+        event_details_page = self.event_details_page
+        error_message = 'This field is required.'


Make this a variable inside EventsPage itself (multiple uses might be possible.)

Monal5031 · 2018-06-05T21:46:34Z

vms/event/tests/test_event.py

+        event_details_page.go_to_events_page()
+
+        self.assertEqual(event_details_page.get_message_context(),
+                         'There are currently no events. Please create events first.')


Same here, class var in EventsPage.

Monal5031 · 2018-06-05T21:47:20Z

vms/event/tests/test_event.py

+        event_details_page.fill_event_form(event_start_after_end)
+
+        # Check error.
+        self.assertEqual(event_details_page.get_event_start_date_error(), 'Start date must be before the end date')


Monal5031 · 2018-06-05T21:47:36Z

vms/event/tests/test_model.py

+        self.assertEqual(str(event_in_db.start_date), event[1])
+        self.assertEqual(str(event_in_db.end_date), event[2])
+
+    # Checks are missing from model class


Raise issue after confirmation in tomorrow's meeting.

~~Workaround~~ Solution found:
model validation checks aren't performed until a full_clean is called explicitly from code/command-line, Forms perform full_clean on submit thats why the error messages are shown. Thus model.save() will save the instance unless there not-null constraint is broken.

Does it make sense to use the workaround for now and file an issue to fix the bug later?

Well its not a workaround per se, as I explained in the later part that model.save() doesnt actually executes the validation checks we need clean or full clean for it which is done by default in forms so there we can see an error while saving i.e.form.save but not in model.save. Ideally we should have a custom clean function in model to raise error while model save.

Monal5031 · 2018-06-05T21:48:01Z

vms/event/tests/test_model.py

+        self.assertEqual(event_in_db.name, 'new-event-name')
+        self.assertEqual(len(Event.objects.all()), 1)
+
+    # Clear function needs to be implemented for this.


~~Workaround~~ Solution found:
model validation checks aren't performed until a full_clean is called explicitly from code/command-line, Forms perform full_clean on submit thats why the error messages are shown. Thus model.save() will save the instance unless there not-null constraint is broken.

Monal5031 · 2018-06-05T21:49:35Z

vms/event/tests/test_shiftSignUp.py

@@ -172,77 +157,77 @@ def test_shift_sign_up_with_outdated_shifts(self):

        # on jobs page
        sign_up_page.click_to_view_shifts()
-        self.assertEqual(sign_up_page.get_info_box().text,'There are currently no shifts for the job job.')
+        self.assertEqual(sign_up_page.get_info_box().text, 'There are currently no shifts for the job job.')


Class var in EventsPage

naman1901 · 2018-06-06T15:08:34Z

vms/event/tests/test_shiftSignUp.py

-        shift_1 = ["2016-05-11","9:00","15:00",6,Job.objects.get(name = 'job')]
-        s1 = create_shift_with_details(shift_1)
+        shift_1 = ["2016-05-11", "9:00", "15:00", 6, Job.objects.get(name='job')]
+        create_shift_with_details(shift_1)


If something is returned, it is good practice to store the return value even if you're not using it. Someone else might want it later, but this way they'll think the function returns nothing.

naman1901 · 2018-06-06T15:09:05Z

vms/event/tests/test_shiftSignUp.py

        v2 = create_volunteer_with_details(volunteer_2)

        # Assign shift to the volunteer
-        vol_shift = register_volunteer_for_shift_utility(s2, v2)
+        register_volunteer_for_shift_utility(s2, v2)


Capture return value

codacy was marking it as unused variable and failing. 😞

I'll delete codacy comments, not to worry!

naman1901

Please update us on the workaround/bugfix issue.
It is good practice to capture return values even if you don't use them.

prachi1210 · 2018-06-07T18:27:26Z

Review awaited from Anjali, Update and finalise PR and ping me on Slack @Monal5031

anjali-dhanuka

LGTM

Monal5031 added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. category: testing labels Jun 3, 2018

Monal5031 assigned pavankm and naman1901 Jun 3, 2018

Monal5031 requested review from pavankm, naman1901 and prachi1210 June 3, 2018 16:58

Monal5031 force-pushed the testing-event branch from 8214386 to 0c00402 Compare June 3, 2018 17:10

anitab-org deleted a comment Jun 3, 2018

Monal5031 force-pushed the testing-event branch from 0c00402 to aaa1dc6 Compare June 5, 2018 15:21

Monal5031 commented Jun 5, 2018

View reviewed changes

naman1901 reviewed Jun 6, 2018

View reviewed changes

prachi1210 requested a review from anjali-dhanuka June 7, 2018 18:26

Monal5031 force-pushed the testing-event branch 4 times, most recently from b3fbf6b to 82ccfda Compare June 10, 2018 02:28

anitab-org deleted a comment Jun 10, 2018

Monal5031 force-pushed the testing-event branch from 82ccfda to 02ed063 Compare June 10, 2018 03:20

anitab-org deleted a comment Jun 10, 2018

Monal5031 force-pushed the testing-event branch from c8246a4 to fb1d214 Compare June 10, 2018 04:14

anitab-org deleted a comment Jun 10, 2018

Tests for Event app

fb1d214

naman1901 approved these changes Jun 10, 2018

View reviewed changes

anjali-dhanuka reviewed Jun 10, 2018

View reviewed changes

prachi1210 merged commit 67b84ee into anitab-org:gsoc18-infra Jun 13, 2018

Monal5031 deleted the testing-event branch June 13, 2018 17:23

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 2, 2018

Tests for Event app (#707)

7c0a0c2

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 2, 2018

Tests for Event app (#707)

ba3a114

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 3, 2018

Tests for Event app (#707)

be368d0

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 3, 2018

Tests for Event app (#707)

045c737

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 4, 2018

Tests for Event app (#707)

09a5a6a

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 6, 2018

Tests for Event app (#707)

cc058ac

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 14, 2018

Tests for Event app (#707)

469f186

mayburgos unassigned pavankm Feb 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests for Event app #707

Tests for Event app #707

Monal5031 commented Jun 3, 2018 •

edited

Loading

Monal5031 left a comment •

edited

Loading

Monal5031 Jun 5, 2018

Monal5031 Jun 7, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 7, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 7, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 7, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 6, 2018 •

edited

Loading

naman1901 Jun 6, 2018

Monal5031 Jun 6, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 6, 2018 •

edited

Loading

Monal5031 Jun 5, 2018

Monal5031 Jun 7, 2018

naman1901 Jun 6, 2018

naman1901 Jun 6, 2018

Monal5031 Jun 6, 2018

prachi1210 Jun 7, 2018

naman1901 left a comment

prachi1210 commented Jun 7, 2018 •

edited

Loading

anjali-dhanuka left a comment

Tests for Event app #707

Tests for Event app #707

Conversation

Monal5031 commented Jun 3, 2018 • edited Loading

Description

Type of Change:

How Has This Been Tested?

Checklist:

Monal5031 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monal5031 Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monal5031 Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman1901 left a comment

Choose a reason for hiding this comment

prachi1210 commented Jun 7, 2018 • edited Loading

anjali-dhanuka left a comment

Choose a reason for hiding this comment

Monal5031 commented Jun 3, 2018 •

edited

Loading

Monal5031 left a comment •

edited

Loading

Monal5031 Jun 6, 2018 •

edited

Loading

Monal5031 Jun 6, 2018 •

edited

Loading

prachi1210 commented Jun 7, 2018 •

edited

Loading