This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monal5031
added
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Program: GSOC
Related to work completed during the Google Summer of Code Program.
category: testing
labels
Jun 16, 2018
Monal5031
commented
Jun 16, 2018
@@ -11,9 +11,10 @@ | |||
|
|||
def check_correct_volunteer(func): | |||
@wraps(func) | |||
def wrapped_view(request, volunteer_id): | |||
def wrapped_view(request, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prachi1210 @naman1901 @pavankm This is the fix needed for #725
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it not create merge issues later if both you and @anjali-dhanuka make changes in separate PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, actually she is not doing this issue she did the other one.
10 tasks
Monal5031
force-pushed
the
testing-shift
branch
2 times, most recently
from
July 20, 2018 11:52
4b535cf
to
7f6046c
Compare
and add Docstrings for shift hours tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Program: GSOC
Related to work completed during the Google Summer of Code Program.
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested shift app
Closes #720 #725
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
To verify that tests are non-breaking change in job app use:
and to overall project use:
Checklist:
Code/Quality Assurance Only