Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Tests for Shift App #726

Merged
merged 4 commits into from
Jul 20, 2018
Merged

Conversation

Monal5031
Copy link
Contributor

@Monal5031 Monal5031 commented Jun 16, 2018

Description

Tested shift app

  • Uncommented and corrected the commented tests
  • Write new tests
  • Move tests from automated-testing repo.

Closes #720 #725

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test shift -v 2

and to overall project use:

python manage.py test

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • [x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Monal5031 Monal5031 added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. category: testing labels Jun 16, 2018
@@ -11,9 +11,10 @@

def check_correct_volunteer(func):
@wraps(func)
def wrapped_view(request, volunteer_id):
def wrapped_view(request, **kwargs):
Copy link
Contributor Author

@Monal5031 Monal5031 Jun 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prachi1210 @naman1901 @pavankm This is the fix needed for #725

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it not create merge issues later if both you and @anjali-dhanuka make changes in separate PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually she is not doing this issue she did the other one.

@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jun 16, 2018
@anitab-org anitab-org deleted a comment Jul 18, 2018
@anitab-org anitab-org deleted a comment Jul 18, 2018
@anitab-org anitab-org deleted a comment Jul 18, 2018
@anitab-org anitab-org deleted a comment Jul 18, 2018
@Monal5031 Monal5031 force-pushed the testing-shift branch 2 times, most recently from 4b535cf to 7f6046c Compare July 20, 2018 11:52
and add Docstrings for shift hours tests
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@anitab-org anitab-org deleted a comment Jul 20, 2018
@mayburgos mayburgos merged commit aa29510 into anitab-org:gsoc18-infra Jul 20, 2018
@Monal5031 Monal5031 deleted the testing-shift branch August 11, 2018 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants