-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
@vubo Awesome. 👍 Change the subject to something like Change the message body to something like Dear Valeria, This is your reminder that you have registered for the Volunteer Coordinator job at the GHC 2015 event on 2015-07-22. Shift Start Time: 12:00:00 Address: Test address Thank you for registering! One more thing is it in the requirements that the this should be run on the server once a day and not at the time when someone registers for the job? |
@tapasweni-pathak thank you very much, I will correct it!
When the shift is on 22.07.2015 and someone registers for this shift on 22.06.2015, we have to schedule a notification sending on the 15.07.2015 (one week) or on the 21.07.2015 (one day). Do I understand correctly? Why does this version is better? |
Okay. You told me something more. This is great. 👍 But I was asking that are we sending the notification to her immediately at the time when she registers herself for some shift? |
Do you mean a confirmation email for registration to a shift? No, not yet. But it's a good idea! |
Yes. Right catch. 👍 But then this is a reminder, no? We are reminding her that you have registered for so and so shift. |
Yes, here is the issue: #70 |
Okay. Then I have changed the message body and subject a bit. @vubo One more thing, then change the function name to send_reminder instead of send_notification. But if you are gonna use the same for sending confirmation and hence generalizing the function, then this name is fine. |
Upgrade:
The Systers - VMS Volunteer Shift Reminder Mail
|
Awesome. 👍 Can you rebase? |
@tapasweni-pathak ready 👍 |
@vubo Forgot to tell you before, can you change the commit message also. r/email notifications/Volunteer Shift Reminder Emails |
@tapasweni-pathak thank you, I did it. |
Email notifications (Reminders)
Issue #70
The new function
send_notification(days)
sends one day or one week shift-notifications to all volunteers who signed up for the shift. This function should be run on the server once a day.Example data:
Notification email example for the data:
Please correct me if needed.
I also wrote a unit test for this function.