Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to distinguish kanji variants #94

Closed
ghost opened this issue Feb 2, 2024 · 5 comments
Closed

Add information to distinguish kanji variants #94

ghost opened this issue Feb 2, 2024 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 2, 2024

As I explained in the recent issue (#90), there's currently no way to distinguish between variant forms.

I suggest adding an option that shows the number of strokes so that in most cases I can know what form the answer is.

I think this is a good idea because things about itaiji are complicated and sometimes controversial.

@ghost ghost mentioned this issue Feb 3, 2024
@syt0r
Copy link
Owner

syt0r commented Feb 6, 2024

I see, so info regarding stroke count is not a guarantee that variants can be distinguished. I think it's important to allow users distinguish characters by default. If it's not possible to do with stroke count, how about adding a label with character's code?

I just found one of the characters you mentioned in kanjidic2 file and seems it provides some info about variants
image

I could write a script to filter characters that have variants and get their jis208 codes, if it won't be a huge list I could hardcode those values in the app. These codes will be shown only for characters that have variants. Maybe it;s possible to get jis208 codes programmatically as well, so it would be required to only find characters with variants

Is there any other way natives use to distinguish kanji variants? Because it's quite a technical info 😅

@syt0r
Copy link
Owner

syt0r commented Feb 6, 2024

Then how about we add a unicode code and right next to it a hidden text with another variant or all other variants except of current one that should be clicked to reveal it

@syt0r
Copy link
Owner

syt0r commented Feb 6, 2024

Unicode label is just to create some kind of distinguishing association so that user won't need to see other kanji variants and spoil its form. I was thinking to make this hidden text act like a spoiler on websites and messenger apps, like it's a gray box until you click it. I don't want to make it expandable because it will shift expressions

Do you think the stroke count label feature is still needed with if this feature is implemented?

@ghost ghost closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@syt0r syt0r changed the title Show stroke count in writing practice Add information to distinguish kanji variants Feb 8, 2024
@syt0r syt0r reopened this Feb 8, 2024
syt0r added a commit to syt0r/Kanji-Dojo-Data that referenced this issue Feb 14, 2024
syt0r added a commit to syt0r/Kanji-Dojo-Data that referenced this issue Feb 14, 2024
syt0r added a commit to syt0r/Kanji-Dojo-Data that referenced this issue Feb 14, 2024
@syt0r
Copy link
Owner

syt0r commented Feb 15, 2024

Here what I'm planning to do

Screencast.from.15.02.24.11.51.28.webm

@syt0r
Copy link
Owner

syt0r commented Feb 29, 2024

By the way, I just noticed one interesting thing with Japanese translation during practice, there can be situations when you are reviewing a character and it could be seen in the info section 😅 like kanji from 訓音読、and some of characters used in variants description like 画 and 體 from 異體字. Can these labels be described using only kana in an understandable way or if it's clear enough for natives even use english translations here?

@syt0r syt0r closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant