Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フォルダーを削除できないときダイアログボックスで知らせる #5111

Merged
merged 2 commits into from
Jul 7, 2019

Conversation

u1-liquid
Copy link
Contributor

Summary

フォルダーを削除できないときダイアログボックスで知らせます

@syuilo
Copy link
Member

syuilo commented Jul 6, 2019

もう存在しないフォルダを削除するエラーって通常の操作で発生するかな?

@acid-chicken
Copy link
Member

ストリーミングが途切れたら発生すると思う

@syuilo
Copy link
Member

syuilo commented Jul 6, 2019

そういうケースまで網羅するとエラーメッセージの翻訳が膨大にまってしまいそうなので頻繁に発生する可能性のあるエラーだけでもいいかも?

@u1-liquid
Copy link
Contributor Author

no-such-folder は外した方がいいの?

@syuilo
Copy link
Member

syuilo commented Jul 6, 2019

そう思う><

@u1-liquid u1-liquid force-pushed the show-error-msg-folder-delete branch from dff12e2 to d08d5c7 Compare July 7, 2019 05:54
@u1-liquid
Copy link
Contributor Author

かんりょ

@syuilo syuilo merged commit 3b8ea90 into misskey-dev:develop Jul 7, 2019
@syuilo
Copy link
Member

syuilo commented Jul 7, 2019

ありがとうございます🙏

@u1-liquid u1-liquid deleted the show-error-msg-folder-delete branch July 7, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants