Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in P25 DUID? #52

Closed
sbromberger opened this issue Mar 3, 2015 · 1 comment
Closed

bug in P25 DUID? #52

sbromberger opened this issue Mar 3, 2015 · 1 comment

Comments

@sbromberger
Copy link

Hi all,

I'm looking through dsd_frame.c, and at https://github.com/szechyjs/dsd/blob/master/dsd_frame.c#L270-280 is where the 4-bit DUID is extracted. However, I notice that even though 2 dibits are read, only the most significant bits of each are used (and subsequently compared). Is this intentional?

The reason I ask is because the trunking protocol uses a DUID of 0x7 or 0xC which can't be represented by 2 bits.

@sbromberger
Copy link
Author

Ok, on a deeper look we're just creating [0-3][0-3] representations of the dibit. Sorry to have bothered you. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant