Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move play/pause button #32

Open
t-makaro opened this issue Feb 3, 2019 · 2 comments · May be fixed by #46
Open

Move play/pause button #32

t-makaro opened this issue Feb 3, 2019 · 2 comments · May be fixed by #46
Milestone
0.5.0

Comments

@t-makaro
Copy link
Owner

t-makaro commented Feb 3, 2019

When text for the value of the timeline slider is long, the play/pause button can cover it up.

We have a few options:

  1. Place the text for the slider below. (Probably not doable without making a custom slider).
  2. Move the default button placement below the slider.
  3. Make the button placement intelligent.

I am aiming for 2.

Also, it is worth considering adding a keyword argument that will move the button between the current placement and the new placement.
@t-makaro t-makaro added this to the 0.4 milestone Feb 3, 2019
@t-makaro
Copy link
Owner Author

t-makaro commented Feb 4, 2019

Related #20

@t-makaro t-makaro modified the milestones: 0.4, 0.5.0 Feb 22, 2019
This was referenced Apr 29, 2019
Closed
Open
@TomNicholas
Copy link
Contributor

In #46 I tried to solve this with a 4th option:

  1. Make the slider size intelligent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
2 participants
@t-makaro @TomNicholas