Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BunchOfFiles writer incompatible with matplotlib-3.4 #58

Closed
johnomotani opened this issue Apr 6, 2021 · 3 comments
Closed

BunchOfFiles writer incompatible with matplotlib-3.4 #58

johnomotani opened this issue Apr 6, 2021 · 3 comments
Labels
testing

Comments

@johnomotani
Copy link
Contributor

The implementation of matplotlib.animation.FileMovieWriter seems to have changed in matplotlib-3.4, and the _frame_sink member no longer exists. This makes the unit tests fail. I guess BunchOfFiles needs to be updated, maybe following the patters in matplotlib.animation https://matplotlib.org/stable/_modules/matplotlib/animation.html?
@t-makaro
Copy link
Owner

t-makaro commented Apr 7, 2021 •
edited
Loading

Dev note: Relevant Matplotlib change: matplotlib/matplotlib#19045

@t-makaro
Copy link
Owner

t-makaro commented Apr 7, 2021

Looks like a straight swap of _frame_sink with self._proc.stdin, and maybe removing the finish() function. Looks like this will be backwards compatible with older matplotlib too.

@t-makaro
Copy link
Owner

I'm looking at fixing this within the next few days. It's top priority before I can do anything else.

@t-makaro t-makaro mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnomotani @t-makaro