Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate element then non-drag reposition gets confused #374

Closed
pelrun opened this issue Jun 29, 2016 · 4 comments · Fixed by #590
Closed

Duplicate element then non-drag reposition gets confused #374

pelrun opened this issue Jun 29, 2016 · 4 comments · Fixed by #590
Labels

Comments

@pelrun
Copy link
Contributor

pelrun commented Jun 29, 2016

Was making several copies of a design by right-clicking and selecting "duplicate", then modifying the fields in the position tab. Things then got a bit screwy, with the original cut vanishing, and the copy not being selectable, and selecting via the file dropdown didn't produce the expected result either. So some internal state is getting confused.

If I duplicate the design and then drag the copy away, then everything works properly and I can reposition both copies with the position tab without any problems.

@mgmax
Copy link
Collaborator

mgmax commented Feb 19, 2020

How to reproduce this bug:

  • Load file (e.g. circle-20mm-red.svg from the examples)
  • Drag to x=100mm (exact value does not matter)
  • right-click
  • duplicate
  • do not drag, but go to the "position tab", set x=200mm, press enter key

Expected:

  • first file is at x=100mm, second file at x=200mm

Actual result:

  • first file disappears from the preview, but can somehow still be selected from the dropdown.

@mgmax mgmax added the Bug label Feb 19, 2020
@cdemeijer
Copy link
Contributor

My first guess was that it is related to GraphicSet.clone method. I'm totally new to VisiCut and just messing with the code for now.
Although I seem to have it fixed locally, I'm not (at all) sure that I didn't break the code somewhere else.
Will clean up and test more tonight.

@cdemeijer
Copy link
Contributor

PR submitted. Hope that submitting a PR for the master branch is the correct way. I couldn't find the develop branch mentioned in the developers documentation :/

@t-oster
Copy link
Owner

t-oster commented Sep 30, 2020

Yes, we switched to a more agile way with master being the latest version and instant release. Thanks for the PR

t-oster added a commit that referenced this issue Sep 30, 2020
Fixes #374: Duplicate element then non-drag reposition gets confused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants