Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why did you just put this in the php branch of json.minify #13

Open
emahuni opened this issue Sep 30, 2016 · 4 comments
Open

why did you just put this in the php branch of json.minify #13

emahuni opened this issue Sep 30, 2016 · 4 comments

Comments

@emahuni
Copy link

emahuni commented Sep 30, 2016

i THINK it was going to be more helpful and useful there.

@t1st3
Copy link
Owner

t1st3 commented Sep 30, 2016

Can't remember why I created this package rather than contributing to json.minify... Most probably because I needed a PHP class instead of just a function.
I'm not sure whether this change was worth contributing to Kyle's json.minify, and at that time, I did not think anybody but me would use this package.
Publishing this on Packagist was merely some personal test of Composer/Packagist features and their integration with GitHub.
Finally, this package has a minimal test and basic API documentation; maybe some of those changes are worth integrating in the original package.
cc @getify please tell me if you're interested in me contributing to your package for any of this.

@getify
Copy link

getify commented Sep 30, 2016

Definitely happy to accept implementations on the main repo. if it replaces an existing impl, maybe file an issue first asking for a new branch so we don't lose existing options.

@emahuni
Copy link
Author

emahuni commented Oct 8, 2016

This is definitely welcome... Looking forward to pointing my barrels of composer require there. This is awesome.

@emahuni
Copy link
Author

emahuni commented Oct 8, 2016

@getify pliz announce here when adding it to Json minify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants