Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ID from XbiResult #17

Closed
1 task
dndll opened this issue Feb 20, 2023 · 0 comments · Fixed by #40
Closed
1 task

Remove ID from XbiResult #17

dndll opened this issue Feb 20, 2023 · 0 comments · Fixed by #40
Assignees
@dndll
Labels
good first issue Good for newcomers

Comments

@dndll
Copy link
Contributor

dndll commented Feb 20, 2023

Item Type

Task

Description

Remove the id field from XbiResult since we have it in the metadata anyway.

Additional Information

Update the codec to remove the id. Everything should take the id from the metadata.

Acceptance Criteria

id is removed and tests pass

What are the points assigned to this item?

None

Is the issue ready?

  • This issue is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dndll dndll

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: encapsulate private fields from the user request t3rn/xbi
1 participant
@dndll