Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate deployment to MyGet and NuGet.org #49

Closed
kevinkuszyk opened this issue Jun 8, 2017 · 12 comments
Closed

Automate deployment to MyGet and NuGet.org #49

kevinkuszyk opened this issue Jun 8, 2017 · 12 comments
Milestone

Comments

@kevinkuszyk
Copy link
Member

Follow on from #48.

  • CI builds (all branches except master and PRs) should automatically publish to MyGet.
  • When we create a tag from master (i.e. create a release in GitHub) we should automatically publish to NuGet.org.
@valeriob
Copy link
Contributor

Hi, how close is this ? i could help testing it with a consumable package

@valeriob
Copy link
Contributor

Stupid followup question, i downloaded the src, linked the project R4Mvc, now how do i cfg and run it ? :D
Thanks

@valeriob
Copy link
Contributor

Meanwhile i'm trying to run it manally, but i get the following error :
Msbuild failed when processing the file 'C:\Users\vborioni\Downloads\R4MVC-master (1)\R4MVC-master\src\R4MvcHostApp\R4MvcHostApp.csproj' with message: The imported project "C:\Users\vborioni\Downloads\R4MVC-master (1)\R4MVC-master\src\R4Mvc.Tools\bin\Debug\net462\Sdks\Microsoft.NET.Sdk.Web\Sdk\Sdk.props" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk. C:\Users\vborioni\Downloads\R4MVC-master (1)\R4MVC-master\src\R4MvcHostApp\R4MvcHostApp.csproj

I'm using Vs 2017, and i have .net core 2.0 preview 2 installed.

@kevinkuszyk
Copy link
Member Author

@valeriob getting the package up on MyGet might take a few more weeks (the kids are off at the moment as it's school holidays here in the UK and busy time at the allotments).

@artiomchi any tips for running it locally using a custom build?

@valeriob
Copy link
Contributor

Hi,
i tried to set the env variable "MSBuildSDKsPath" to "c:\Program Files\dotnet\sdk\2.0.0-preview2-006497\Sdks" but now i get a different error :
Msbuild failed when processing the file 'C:\Users\vborioni\Downloads\R4MVC-master (1)\R4MVC-master\src\R4MvcHostApp\R4MvcHostApp.csproj' with message: The imported project "C:\Program Files (x86)\MSBuild\2.0\Microsoft.Common.props" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk. c:\Program Files\dotnet\sdk\2.0.0-preview2-006497\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.props

I do have that installed, but it looks for msbuild 2.0, i've 14 and 15 installed :
image

image

@artiomchi
Copy link
Member

Hi @valeriob

You shouldn't have to change the env variables to build the project. My guess is that you've installed .NET Core 2.0 Preview 2, while I build it against 1.1. In any case, I'll be making sure that it works when build against 2.0 shortly.

Regarding your question about adding it to an existing project, I've set up a MyGet feed against my dev branch, so until we have official alpha builds, you could just use my nightlies in the meantime.

You can add the following to your NuGet feeds: https://www.myget.org/F/artiomchi/api/v3/index.json

Then reference R4Mvc and R4Mvc.Tools in your web project.
Once installed, you can run the Generate-R4MVC PowerShell command in the Package Manager Console window in VS to re-generate the classes.

@artiomchi
Copy link
Member

P.S. If you have any issues with the nightly builds or building the code, please open a new issue so that we can help you. I'd rather we keep the issue discussions on topic :)

@valeriob
Copy link
Contributor

valeriob commented Aug 1, 2017

Hi @artiomchi thanks !
I migrated r4mvc to aspnetcore 2.0 but i failed... Well i migrated it and it compiles, but running the tool brings the result you see on my comment above 😄

@artiomchi
Copy link
Member

@kevinkuszyk Once you update the API keys in the yaml file, this issue can be closed too 😄

@kevinkuszyk
Copy link
Member Author

kevinkuszyk commented Aug 22, 2017

@artiomchi what's your NuGet.org username, so I can add you as an owner of the package?

@kevinkuszyk kevinkuszyk reopened this Aug 22, 2017
@artiomchi
Copy link
Member

@kevinkuszyk it's ArtiomChi, same as here :)

Also, thanks for that. That would let me update the release notes after deployments!

@kevinkuszyk
Copy link
Member Author

Done.

Re. release notes - I usually just add them to the tag in GitHub, and put a link to the GitHub releases page in the .nuspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants