Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mods do not sort when searching through download mods in workshop #3792

Closed
Ocwhkn opened this issue Sep 5, 2023 · 0 comments · Fixed by #4047
Closed

Mods do not sort when searching through download mods in workshop #3792

Ocwhkn opened this issue Sep 5, 2023 · 0 comments · Fixed by #4047
Assignees
@Solxanich
Labels
Benefit - Low Complexity - Medium Feature - User Experience Request for new user functionality Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs

Comments

@Ocwhkn
Copy link

Ocwhkn commented Sep 5, 2023

Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects

Gameplay as a Player

Description

When searching mods to download in workshop using a keyword, sorting options do not work.

Log File

client.log

Steps to reproduce

  1. Go to Download Mods under Workshop
  2. Search for mods using keyword, e.g., potion
  3. Click through sorting options in the top left of the box

Expected Behavior

Mods should be sorted as per sorting option (last updated, most popular, most downloaded)

Actual Behavior

Mods are not sorted as expected - even under the default "sort by recently updated", mods do not appear in chronological order. In fact, the mod list order is the same regardless of the sorting option.

Reproduction frequency

Constant, has been an issue since Sep 1st update and has not resolved despite re-installation.

Additional Information

Sorting works fine without a search term - only appears as an issue when a search is applied.
@Ocwhkn Ocwhkn added the NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. label Sep 5, 2023
@github-actions github-actions bot added the Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs label Sep 5, 2023
@Chicken-Bones Chicken-Bones added Feature - User Experience Request for new user functionality Benefit - Low Complexity - Medium and removed NEW ISSUE Flags an Issue as new. To be removed once issue is assessed. labels Sep 14, 2023
Metratrj added a commit to Metratrj/tModLoader that referenced this issue Feb 2, 2024
@Metratrj
fix: Sorting of searched mods through download mods Fixes tModLoader#…
2d4b1a5 
…3792

Added additional sorting when text search is used for the workshop query
@Metratrj Metratrj mentioned this issue Feb 2, 2024
Merged
Metratrj added a commit to Metratrj/tModLoader that referenced this issue Feb 3, 2024
@Metratrj
Merge pull request #1 from Metratrj/fix/moddownloadsort
d4ae529 
fix: Sorting of searched mods through download mods Fixes tModLoader#3792
Solxanich pushed a commit that referenced this issue Feb 11, 2024
@Metratrj
fix: Sorting of searched mods through download mods Fixes #3792 (#4047)
784d048 
* fix: Sorting of searched mods through download mods Fixes #3792

Added additional sorting when text search is used for the workshop query

* fix: Mod download sorting with filtering

fixes the sorting applies for all results also if paged

* Remove unnecessary file change in WorkshopHelper.TML.cs

* Add commenting for CalculateQuerySort
Metratrj added a commit to Metratrj/tModLoader that referenced this issue Feb 24, 2024
@Metratrj @Chicken-Bones
@JavidPack @Solxanich
Sync (#3)
6b3229c 
* fix: Sorting of searched mods through download mods Fixes tModLoader#3792

Added additional sorting when text search is used for the workshop query

* fix: CI add own encrypt assets

* fix: CI Assets

* Install the CodeSee workflow. Learn more at https://docs.codesee.io

* Update build.yml

* more detailed error display when world load/save/clear failes early mod related

Add additional error throwing when mod hooks executed
Add displaying error when world load failes mod related on client
Should Close tModLoader#3401
Should WIP on tModLoader#3988

* refactor exception handling in playWorldCallack

* spawn an error box when world save fails

* Update build.yml

* Improve mod version selection and multiplayer mod sync/reload user experience (tModLoader#3822)

* Add Version helper property to LocalMod

* Add LocalMod.ModLocation and new mod selection priority code

* Rejected -> Skipped in logs

* Allow loading mods from newer build/patch versions.

* Restrict mod loading to the same browser version

* Prefer local mods folder unless hashes match

* Tie UIModItem purple background color and steam icon to new ModLocation

* Use ModLocation for mod deletion code paths

* ModNet can select workshop mod versions when connecting to servers.

* Adjust log formatting of server mods list

* Inform user about pending mod downloads/reloads when joining server

* Show reload menu when click single player, show server mod version warning in mods ui

* Apply feedback

* Add localization to ReloadRequiredExplanations and related

* Address further feedback

---------

Co-authored-by: JavidPack <javidpack@gmail.com>

* Repair ExampleMod Building. Slightly distrust version assigment

* feat: Increase maximum supported length of chest names

Increased the MaxNameLength and start utilizing this variable

* fix: mod version selection tests

Updated the initialisation of local mod and pass down the newly required argument for mod location
Updated the asserted error messages for mod dependencies
Closes tModLoader#4077

* feat: journeys end menu persist on restart

When last selected menu was journeys end it also get loaded on startup

---------

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Co-authored-by: Chicken-Bones <mehvids@gmail.com>
Co-authored-by: JavidPack <javidpack@gmail.com>
Co-authored-by: Solxan <59670736+Solxanich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Solxanich Solxanich

Labels
Benefit - Low Complexity - Medium Feature - User Experience Request for new user functionality Requestor-Player Issues or PRs adding player features or fixing TML gameplay bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Sorting of searched mods through download mods Fixes #3792 Metratrj/tModLoader
3 participants
@Chicken-Bones @Solxanich @Ocwhkn