Fix "UseMana" tooltip #3774
Merged
Fix "UseMana" tooltip #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks clean. |
|
I went ahead and decided it is good to merge as is. It seems a little out of scope to show how mana is adjusted here, since we don't do that in other places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3739
What is the new feature?
Fixes vanilla "UseMana" tooltips not taking into account the various
ModifyManaCosthooks.This also changes Space Gun to say "Uses 0 mana" instead of lacking a tooltip.
Why should this be part of tModLoader?
See issue
Are there alternative designs?
There is more to discuss, we didn't really arrive at a consensus.