Add useTurnOnAnimationStart to restore turn behavior of earlygame vanilla swords #3805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the bug?
How did you fix the bug?
Added
Item.useTurnOnAnimationStart
to allow items to change direction based oncontrolLeft
andcontrolRight
only between animations, and applied this to the relevant vanilla items.Are there alternatives to your fix?
The new flag could instead be checked in
HorizontalMovement
alongsideitemAnimation == 0 || inventory[selectedItem].useTurn
, but this would require more patches, grant no additional useful functionality, and generally be more confusing.Porting Notes
useTurnOnAnimationStart
on their items. Note that this removes the ability to kite backwards, and there is little reason not to setuseTurn
instead to allow the player to turn instantly while using the item.