Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useTurnOnAnimationStart to restore turn behavior of earlygame vanilla swords #3805

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Chicken-Bones
Copy link
Member

What is the bug?

How did you fix the bug?

Added Item.useTurnOnAnimationStart to allow items to change direction based on controlLeft and controlRight only between animations, and applied this to the relevant vanilla items.

Are there alternatives to your fix?

The new flag could instead be checked in HorizontalMovement alongside itemAnimation == 0 || inventory[selectedItem].useTurn, but this would require more patches, grant no additional useful functionality, and generally be more confusing.

Porting Notes

  • Modders with early-game weapons which want to replicate this behavior should set useTurnOnAnimationStart on their items. Note that this removes the ability to kite backwards, and there is little reason not to set useTurn instead to allow the player to turn instantly while using the item.

@Chicken-Bones Chicken-Bones merged commit d11052c into 1.4.4 Sep 12, 2023
@Chicken-Bones Chicken-Bones deleted the autoreuse-useturn branch September 12, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant