Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config List Rework (Config Rework Part 1) #3810

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Destructor-Ben
Copy link
Contributor

Split off from Config UI Rework: #3556

What is the new feature?

Completely reworked config list UI

  • Can now be accessed in the main menu as well as in game
  • Has a list for mods and a list for configs
  • Selecting a mod will show all it's available configs
  • Clicking a config will open it
  • Made the config button on UIModItem in the mods menu to open the config list with the mod selected
  • Added a button to open the mod config list from the mods menu
  • Each config has a red or blue dot indicating whether it is client or server side
    • Red is server, blue is client
    • Hovering over the dot will also say if it is a server side or client side config

Before


Screenshot_20230617_011615

After


image

Screenshot_20230726_083406

Screenshot_20230617_120026

Why should this be part of tModLoader?

Currently the UI for the configs is ugly and confusing and it has been stated many times on the tML discord server that it should be changed. It is also difficult for users to find configs. In the main menu, the only ways to access configs was through the config button (but that only took you to the first one a mod registered), and the rest through the difficult to notice next and previous buttons. In game, there was the config list, which is how I usually changed configs, but you couldn't change the values that would require a reload, so you had to deal with the main menus config UI. In many cases I have never even realized that a mod has multiple configs because of this.

Are there alternative designs?

Sample usage for the new feature

N/A

ExampleMod updates

N/A

@Destructor-Ben Destructor-Ben changed the title Config List Rework Config List Rework (Config Rework Part 1) Sep 16, 2023
@Cyrillya
Copy link
Contributor

Suggestion: Hide the scroll bar when not needed

@JavidPack
Copy link
Collaborator

Looks good. I don't think the scroll bars need to hide, the game doesn't do that with the resource pack menu, so it's consistent with that.

@JavidPack JavidPack merged commit d892f2b into tModLoader:1.4.4 Sep 19, 2023
@Chicken-Bones
Copy link
Member

Suggestion: Hide the scroll bar when not needed

Feel free to contribute a scroll-bar hiding upgrade which works across multiple modded UIs perhaps

@Destructor-Ben Destructor-Ben deleted the Config-UI-Rework-1 branch September 20, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants