Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2020 #3851

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Fix #2020 #3851

merged 1 commit into from
Sep 30, 2023

Conversation

shuen4
Copy link
Contributor

@shuen4 shuen4 commented Sep 29, 2023

originally fixed in 5161f2e but broken after 88c4e68

details

when executing Terraria.ModLoader.Engine.FNAFixes.Init(), Microsoft.Xna.Framework.SDL2_FNAPlatform is not yet initialized

execution routine:

// ...
FNAFixes.Init();
// ...
new Main();
base(); // will initialize FNAPlatform and overwrite previously set SDL_HINT_VIDEO_MINIMIZE_ON_FOCUS_LOSS value

@Chicken-Bones
Copy link
Member

Chicken-Bones commented Sep 30, 2023

Hi, yes, I noticed this recently, but I was considering leaving it in the same place and setting it using HINT_PRIORITY_OVERRIDE

@shuen4
Copy link
Contributor Author

shuen4 commented Sep 30, 2023

changed to use SDL_SetHintWithPriority and SDL_HINT_OVERRIDE in 17b0802

@Chicken-Bones Chicken-Bones merged commit e3317a5 into tModLoader:1.4.4 Sep 30, 2023
Chicken-Bones pushed a commit that referenced this pull request Oct 4, 2023
Solxanich pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants