Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese translation supplement #3858

Merged
merged 10 commits into from Oct 3, 2023
Merged

Simplified Chinese translation supplement #3858

merged 10 commits into from Oct 3, 2023

Conversation

Fish-cat-cat
Copy link
Contributor

@Fish-cat-cat Fish-cat-cat commented Oct 2, 2023

What's in PR?

This PR has a Simplified Chinese translation supplement for tModLoader and some Simplified Chinese translation supplements for Steam

What did you translate?

See commits

I know of another PR who also submitted the same content

@JavidPack
Copy link
Collaborator

I'm not quite sure what to do about the overlap between this and #3854, can you two talk and maybe consolidate the best translations into a single PR? I'm not really able to judge which is better myself.

@Fish-cat-cat Fish-cat-cat marked this pull request as draft October 3, 2023 07:53
Fish-cat-cat and others added 4 commits October 3, 2023 16:01
Co-Authored-By: Lacewing <103016663+lyc-Lacewing@users.noreply.github.com>
Co-Authored-By: Lacewing <103016663+lyc-Lacewing@users.noreply.github.com>
@Fish-cat-cat Fish-cat-cat marked this pull request as ready for review October 3, 2023 09:55
@JavidPack
Copy link
Collaborator

Looks good. I'll get these uploaded within a day or 2.

@JavidPack JavidPack merged commit 60c2fb5 into tModLoader:1.4.4 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants