1.4.4 CanOpen hook #3972
Open
1.4.4 CanOpen hook #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CanRightClick to have a Player parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the new feature?
Adds a CanOpen hook to the ModItem class for modded items to override to determine if this item is consumable. References this issue: #3802
Why should this be part of tModLoader?
Gives greater control over modded lootbags to creators.
Are there alternative designs?
You could check whether or not an item can be opened in the CanRightClick function within ItemLoader, but that design tends to mix functionality together and is not ideal.
Sample usage for the new feature
Added the ExampleKeyBag and ExampleGoldenKey to test the new feature. To add a bit to the conditions, the ExampleGoldenKey opens the ExampleKeyBag if and only the world is in Hardmode and there is a ExampleGoldenKey in the current player's inventory.
ExampleMod updates
See above.