Remove redundant and erroneous PPID reassignment in launch script #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the bug?
PPIDis a readonly variable, and cannot be reassigned. Our attempt to do so was erroneous. Most of the time bash carries on anyway, but this creates a misleading error in the logs.The bug has been present since the initial implementation in c06e433#diff-e97dbf4a5db5bcbb88768f7ee813b288259c7947f7ca24a468d1104942f991b9
Somehow @covers1624 and I missed the error message (and the fact it didn't do anything and wasn't needed) in our testing
How did you fix the bug?
Removed the offending code. I validated that steam playtime tracking for Terraria continues to work as expected on both Mac and Linux, and that
$PPIDis still the same without the explicit pass-through (because./execution runs in the same shell process).Are there alternatives to your fix?
No