Zip library updated from Ionic.Zip.Reduced v1.9.1.8 to DotNetZip v1.16.0 #4109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that would cause world saving to hang indefinitely for some users in some specific worlds (https://discord.com/channels/103110554649894912/1216826270818504714 is the support thread where the solution was finally discovered). There were mentions of similar bugs on the bug tracker that were fixed
https://github.com/haf/DotNetZip.Semverd/issues/38
in the zip library we use. This fix is later than our original v1.9.1.8 release. When testing the updated dotnetzip library with the world that wasn't able to save, the issue appears fixed now.It is unclear how many are affected by this bug, but the save issue has been an unknown issue that has stumped us for some time now, it just hadn't been replicated by devs until now.
It seems that the library has gone through a rename in the intervening years. Namespaces and classnames are consistent, so source code compatibility is maintained. Binary compatibility is not due to the assembly name change, so additional code has been added to resolve the old assembly name to the new one.
Porting Notes
Nothing should be required by modders.