Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch cannot build #1085

Closed
annevk opened this issue Sep 1, 2017 · 5 comments
Closed

Fetch cannot build #1085

annevk opened this issue Sep 1, 2017 · 5 comments

Comments

@annevk
Copy link
Collaborator

annevk commented Sep 1, 2017

Something you did in the last 12h or so causes Fetch to fail building. The following is what I get back from the CSSWG API server:

Error running preprocessor, returned code: 1.
Traceback (most recent call last):
  File "/sites/api.csswg.org/bikeshed/bikeshed.py", line 5, in 
    bikeshed.main()
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 193, in main
    doc.preprocess()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 171, in preprocess
    processBiblioLinks(self)
  File "/sites/api.csswg.org/bikeshed/bikeshed/unsortedJunk.py", line 626, in processBiblioLinks
    ref = doc.refs.getBiblioRef(linkText, status=refStatus, generateFakeRef=okayToFail, silentAliases=okayToFail, el=el)
  File "/sites/api.csswg.org/bikeshed/bikeshed/refs/ReferenceManager.py", line 483, in getBiblioRef
    bib = self.getBiblioRef(candidate["aliasOf"], status=status, el=el, quiet=True)
  File "/sites/api.csswg.org/bikeshed/bikeshed/refs/ReferenceManager.py", line 480, in getBiblioRef
    bib = biblio.StringBiblioEntry(**candidate)
  File "", line 22, in __init__
  File "/sites/api.csswg.org/bikeshed/bikeshed/biblio.py", line 31, in __attrs_post_init__
    self.preferredURL = config.refStatus.snapshot
  File "/sites/api.csswg.org/bikeshed/bikeshed/attr/_make.py", line 240, in _frozen_setattrs
    raise FrozenInstanceError()
bikeshed.attr.exceptions.FrozenInstanceError
@foolip
Copy link
Collaborator

foolip commented Sep 1, 2017

I have bisected and this specific exception started happening in commit 3172faa, the the preceding commit 5cca8a7 had another issue. On of those two commits are the cause, though.

@foolip
Copy link
Collaborator

foolip commented Sep 1, 2017

Tested with make local in whatwg/fetch@c193559

@foolip
Copy link
Collaborator

foolip commented Sep 1, 2017

The problem applies to the master branch of fetch as well, but not dom. It must have something to do with this bit in the source:

    "HTTP": {
        "aliasOf": "HTTP11"
    },
    "HTTP-SEMANTICS": {
        "aliasOf": "RFC7231"
    },
    "HTTP-COND": {
        "aliasOf": "RFC7232"
    },
    "HTTP-CACHING": {
        "aliasOf": "RFC7234"
    },
    "HTTP-RANGE": {
        "aliasOf": "RFC7233"
    },
    "HTTP-AUTH": {
        "aliasOf": "RFC7235"
    },
    "REFERRER": {
        "aliasOf": "referrer-policy"
    },
    "SW": {
        "aliasOf": "service-workers"
    },
    "UPGRADE": {
        "aliasOf": "upgrade-insecure-requests"
    },
    "HSTS": {
        "aliasOf": "rfc6797"
    },
    "WSP": {
        "aliasOf": "WEBSOCKETS-PROTOCOL"
    },

@foolip
Copy link
Collaborator

foolip commented Sep 1, 2017

@tabatkins, is there an open issue for regression testing using all known existing specs using Bikeshed? If the main problem is getting and keep a list of repos up-to-date, that's something I think might naturally fall out of other things I'd like to do, so I'm interested to help.

@tabatkins
Copy link
Collaborator

Fixed, sorry. Was testing against DOM, but it doesn't exercise this particular path, and none of my automatic tests were using a string-based biblio entry either; I'll fix that.

@foolip No open issue yet; I'll open one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants