Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for constructor operation support #1513

Closed
Ms2ger opened this issue Aug 29, 2019 · 5 comments
Closed

Update for constructor operation support #1513

Ms2ger opened this issue Aug 29, 2019 · 5 comments

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 29, 2019

Probably just needs plinss/widlparser#44 to be imported.

@plinss
Copy link
Contributor

plinss commented Aug 29, 2019

widlparser has been updated.

Note that extended attribute constructors are exposed by the 'constructors' property, but constructor operations are not, they're just regular methods. Both are exposed by the 'members' property but constructor operations have a 'method' idlType while the [Constructor] and [NamedConstructor] attributes have a 'constructor' idlType.

Let me know if this is going to be an issue for bikeshed, but it was necessary to differentiate them within widlparser.

@foolip
Copy link
Collaborator

foolip commented Aug 30, 2019

Sent #1514 if anyone has the power to review.

@birtles
Copy link
Contributor

birtles commented Sep 9, 2019

It seems like this doesn't linkify constructor? (Unlike [Constructor] which was link-ified.) And it doesn't correctly linkify the arguments of the constructor either with constructor scope?

Is that right, or am I just doing it wrong?

@foolip
Copy link
Collaborator

foolip commented Sep 9, 2019

That's right, see #1519.

@birtles
Copy link
Contributor

birtles commented Sep 9, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants