Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Product view #98

Open
simenandre opened this issue Dec 29, 2020 · 2 comments
Open

Refactor Product view #98

simenandre opened this issue Dec 29, 2020 · 2 comments
Labels
needs-triage Needs attention from the triage team

Comments

@simenandre
Copy link
Member

We should probably be using only one Formik instance and one default values/type.

It will probably brake the way it works right now. Right now, the tabs are separated so that you have to store the changes before moving to the next.

@AnneMatilde would that be okey?
@simenandre simenandre mentioned this issue Dec 29, 2020
Draft
@AnneMatilde
Copy link
Contributor

Thats fine!

@simenandre
Copy link
Member Author

After doing some research, I think the approach here should be having the same types as UpdateProductInput or CreateProductInput. The thing I'm trying to do here as well is to keep the number of types to a minimum.

Postponing this for a while.

@simenandre simenandre added the needs-triage Needs attention from the triage team label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Needs attention from the triage team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simenandre @AnneMatilde