Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how we handle monetary values #99

Open
simenandre opened this issue Dec 29, 2020 · 0 comments
Open

Refactor how we handle monetary values #99

simenandre opened this issue Dec 29, 2020 · 0 comments
Labels
needs-triage Needs attention from the triage team

Comments

@simenandre
Copy link
Member

We have implemented the smaller monetary value, but the way we currently do it is by multiplying with 100. This is not considered a safe way to handle monetary values, but using dinero.js or something would.
@simenandre simenandre mentioned this issue Apr 30, 2021
Merged
@simenandre simenandre added the needs-triage Needs attention from the triage team label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Needs attention from the triage team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simenandre