Fix Pager by making UserItem return a list like the other models (#109)

Fixes #107
tableau · Dec 2, 2016 · c0c31cc · c0c31cc
1 parent e853d7c
commit c0c31cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tableauserverclient/models/user_item.py b/tableauserverclient/models/user_item.py
@@ -119,7 +119,7 @@ def _set_values(self, id, name, site_role, last_login,
 
     @classmethod
     def from_response(cls, resp):
-        all_user_items = set()
+        all_user_items = []
         parsed_response = ET.fromstring(resp)
         all_user_xml = parsed_response.findall('.//t:user', namespaces=NAMESPACE)
         for user_xml in all_user_xml:
@@ -128,7 +128,7 @@ def from_response(cls, resp):
             user_item = cls(name, site_role)
             user_item._set_values(id, name, site_role, last_login, external_auth_user_id,
                                   fullname, email, auth_setting, domain_name)
-            all_user_items.add(user_item)
+            all_user_items.append(user_item)
         return all_user_items
 
     @staticmethod

diff --git a/test/test_user.py b/test/test_user.py
@@ -54,7 +54,7 @@ def test_get_empty(self):
             all_users, pagination_item = self.server.users.get()
 
         self.assertEqual(0, pagination_item.total_available)
-        self.assertEqual(set(), all_users)
+        self.assertEqual([], all_users)
 
     def test_get_before_signin(self):
         self.server._auth_token = None