Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pager by making UserItem return a list like the other models #109

Merged
merged 1 commit into from Dec 2, 2016
Merged

Fix Pager by making UserItem return a list like the other models #109

merged 1 commit into from Dec 2, 2016

Conversation

t8y8
Copy link
Collaborator

@t8y8 t8y8 commented Dec 2, 2016

Fixes #107

graysonarts
graysonarts approved these changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@graysonarts graysonarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change. I'm okay with it since we said the API will be unstable during the 0.x line. I'd let @LGraber weigh in though .

LGraber
LGraber approved these changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@LGraber LGraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior is broken / different from our other endpoints. If a customer already hit this they were probably confused. I am fine with fixing this. THanks for putting it out!

@t8y8 t8y8 merged commit c0c31cc into tableau:development Dec 2, 2016
@t8y8 t8y8 deleted the 107-fix-user-pager branch December 2, 2016 17:38
@t8y8 t8y8 mentioned this pull request Dec 2, 2016
Closed
@t8y8 t8y8 mentioned this pull request Jan 23, 2017
Closed
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
Release 0.6 (tableau#126)
65fbc80 
* Fix tableau#117 by only attempting files with the right extension inside the archive (tableau#118)

* Commenting and Docstring cleanup. A few very small code cleanups (tableau#120)

Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity.

* Small cleanups for various editors. Play nice with built in test-runners (tableau#121)

* Add Py36, update travis to use pycodestyle (tableau#124)

* Add `initial sql` and `query band` support (tableau#123)

Addresses tableau#109 and tableau#110

* Prep for release of 0.6 (tableau#125)

* Prep for release of 0.6

* wordsmithing the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graysonarts graysonarts graysonarts approved these changes

@LGraber LGraber LGraber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8y8 @graysonarts @LGraber