Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The "language" icon is wrong #416

Open
fhfuih opened this issue Dec 29, 2022 · 0 comments
Open

[Bug] The "language" icon is wrong #416

fhfuih opened this issue Dec 29, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@fhfuih
Copy link
Contributor

fhfuih commented Dec 29, 2022

#396 mentioned this problem, but is off-(that)-topic and after maintainer closed the issue. So I would like to re-mention it here in a new issue.

Note that the following CJK characters can be visually different across machines.
Because each character has regional writing differences, and the default font on your machine to render those character must targets a specific region. More on this later.

The issue

In the current "language" icon, the CJK Ideograph (Hanzi/Kanji/Hanja) is wrong. It looks more like 丈, which means to measure/the length of 3.3 meter.
It should be 文, which means culture/literature.

Their visual differences

For 丈, there are only three strokes. The last stroke starts from above the horizontal line, going down vertically first, and then all the way to bottom left. (You can see the number of strokes in the two unicode database links above, at the kTotalStrokes field.)
For 文, there are four strokes. There is one short curve/line (more on this later) above the horizontal line, and another curve strictly below the horizontal line.

The current source code also follows exactly 丈's strokes, with this single path

<path d="M9 3v2c0 4.418 -2.239 8 -5 8"></path>

going down for 2 and then begin a curve. Hence it is wrong.

Proofs: 文 instead of 丈

Apart from their (obvious) semantic differences, below are some icons from other products/sets.

image
Google Translate from WikiMedia

image
Apple Translate, from PhoneArena

How to write 文, exactly

You can check the regional differences in the 文 character by copy-and-paste this character to the Source Han Sans online demo. It is exactly the same font with different regional styles.

Also check out 文's Wikitionary page.
But again, this page's rendering may depend on available fonts.

TLDR: Both Chinese variants have a curve at the top. JP & KR variants have a vertical line above (but at the middle, and it clearly not connected to the other stroke.

Both Chinese variants
image

JP & KR
image

How to draw a correct icon for this iconset?

Since Tabler has already offered specific Japanese and Korean versions of "language" (the non-ideograph ones),
the easiest way is to follow the Chinese variants and draw a curve above (and of course change the M9 3v2 to M9 5 in the wrong stroke).

But if inclusion and generalizability is really desired, I suggest replacing the upper stroke with a dot. This vaguely represents either a curve or a vertical line, and serves additional "styling" purpose. The entire iconset is rounded/welcoming/cute. So that should fit.

More examples of Chinese-variant-文

image

Wikitionary, Handwritten-style font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants