[#162193] Add clearer secondary outlet message #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use an AR callback here because we generate new relay records on update. See Product#replace_relay
|
@giladshanan some specs are failing |
This keeps the logic simpler and should always be safe. Any change results in a new relay instance, so otherwise we'd have to do some safe navigation like: previous_secondary_outlet = @product.relay&.secondary_outlet Not a huge deal but it crossed the line for me of complexity vs value.
|
@LeticiaErrandonea ready for another look |
LeticiaErrandonea
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Screenshot
Additional Context
Optional. Feel free to add/modify additional headers as appropriate, e.g. "Refactorings", "Concerns".
Accessibility